Repository navigation
[CRE-7121] Paginate CapabilitiesRegistry v2 reads in deployment - #24228
Merged
Merged
Conversation
Contributor
|
✅ No conflicts with other open PRs targeting |
GetDONs and the CapReg v2 view fetched a single page of 32 DONs, silently dropping the rest. Fetch all pages for DONs, nodes, capabilities and NOPs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
bolekk
force-pushed
the
cre-7121-capreg-v2-dons-pagination
branch
from
November 18, 2026 23:19
e98ebcc to
1bd0772
Compare
bolekk
marked this pull request as ready for review
November 18, 2026 23:20
product-security-plaid-production
Bot
requested review from
archseer and
graham-chainlink
November 18, 2026 23:20
Fletch153
approved these changes
Nov 18, 2026
amit-momin
approved these changes
Nov 18, 2026
bolekk
enabled auto-merge
November 18, 2026 23:49
justinkaseman
approved these changes
Nov 19, 2026
ecPablo
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg.GetDONsand the CapReg v2 view (state.json) read only the first 32 DONs (MaxDONs), silently dropping the rest. With per-chain "virtual DONs" for shard-1, prod goes past 32 active DONs.ValidateNoDuplicateCapabilitiesAcrossDONstreats a missing DON as "shares a family", soupdate_don/add_capabilitieswould fail on DONs past index 32, and real conflicts there would go undetected.paginatehelper and use it for DONs, DONs-in-family, nodes, capabilities and NOPs (removes the 32/128/128/256 caps).pkghelpers instead of their own limits.Deployment Validation
After bumping in CLD,
state.jsonlists all active CapReg v2 DONs.🤖 Generated with Claude Code