Skip to content

[CRE-7121] Paginate CapabilitiesRegistry v2 reads in deployment - #24228

Merged
bolekk merged 1 commit into
developfrom
cre-7121-capreg-v2-dons-pagination
Nov 19, 2026
Merged

bolekk merged 1 commit into
developfrom
cre-7121-capreg-v2-dons-pagination

Conversation

@bolekk

@bolekk bolekk commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

pkg.GetDONs and the CapReg v2 view (state.json) read only the first 32 DONs (MaxDONs), silently dropping the rest. With per-chain "virtual DONs" for shard-1, prod goes past 32 active DONs. ValidateNoDuplicateCapabilitiesAcrossDONs treats a missing DON as "shares a family", so update_don / add_capabilities would fail on DONs past index 32, and real conflicts there would go undetected.

  • Add a generic paginate helper and use it for DONs, DONs-in-family, nodes, capabilities and NOPs (removes the 32/128/128/256 caps).
  • View getters delegate to the pkg helpers instead of their own limits.

Deployment Validation

After bumping in CLD, state.json lists all active CapReg v2 DONs.

🤖 Generated with Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

GetDONs and the CapReg v2 view fetched a single page of 32 DONs, silently
dropping the rest. Fetch all pages for DONs, nodes, capabilities and NOPs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@bolekk
bolekk force-pushed the cre-7121-capreg-v2-dons-pagination branch from e98ebcc to 1bd0772 Compare November 18, 2026 23:19
@bolekk
bolekk marked this pull request as ready for review November 18, 2026 23:20
@bolekk
bolekk requested review from a team as code owners November 18, 2026 23:20
@bolekk
bolekk requested a review from amit-momin November 18, 2026 23:27
@bolekk
bolekk enabled auto-merge November 18, 2026 23:49
@bolekk
bolekk added this pull request to the merge queue Nov 19, 2026
Merged via the queue into develop with commit 7590289 Nov 19, 2026
332 of 334 checks passed
@bolekk
bolekk deleted the cre-7121-capreg-v2-dons-pagination branch November 19, 2026 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants