Skip to content

(feat): Signer-family job check for CapReg changesets - #24166

Open
justinkaseman wants to merge 2 commits into
developfrom
CRE-7282
Open

justinkaseman wants to merge 2 commits into
developfrom
CRE-7282

Conversation

@justinkaseman

@justinkaseman justinkaseman commented Nov 7, 2026 •

Copy link
Copy Markdown
Contributor

Blocks UpdateDON, AddCapabilities and ConfigureCapabilitiesRegistry when they add extraSignerFamilies to an OCR3 config before every node has an APPROVED consensus job with a key bundle for each requested family (INCIDENT-2694).

  • A node with no such job fails, including when the job was never proposed. Nodes unknown to JD also fail.
  • Only the latest revision of a live job counts. The consensus job is identified as a standard capability whose command ends in consensus, with bundles under onchainSigningStrategy.config.
  • No families requested means no check and no JD needed, so existing pipelines are unaffected.
  • skipSignerFamilyJobCheck bypasses it on all three inputs.
  • UpdateDON and AddCapabilities resolve DONs by name, so DONs beyond the first 32 are covered.

Limits: the check runs at proposal time, not MCMS execution, and APPROVED does not prove the node is running the job.

Follow-up in chainlink-deployments: resolver passthrough for the new flag and a go.mod bump.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

👋 justinkaseman, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

✅ No conflicts with other open PRs targeting develop

@justinkaseman justinkaseman changed the title (feat): Job acceptance gate for ConfigureCapabilitiesRegistry & UpdateDON (feat): Job acceptance gate for CapReg changesets Nov 9, 2026
@justinkaseman
justinkaseman requested a balanced review from Copilot November 9, 2026 18:04

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The job acceptance gate can miss blocking jobs for duplicate or unnormalized peer IDs, while the truncated DON lookup can incorrectly block updates beyond the first 32 records.

3 open issues
What changed in this PR

Adds a job-acceptance gate to capabilities registry changesets to prevent configuration changes before node operators accept updated job specifications.

Changes:

  • Checks target nodes’ latest job proposals in JD, blocking proposed, pending, or rejected proposals.
  • Adds an explicit bypass and skips nodes not found in JD.
  • Adds tests for proposal statuses, lookup behavior, errors, and bypass handling.
File Description
deployment/​cre/​capabilities_registry/​v2/​changeset/​update_nodes_changeset.go Gates node updates on job acceptance.
deployment/​cre/​capabilities_registry/​v2/​changeset/​update_don.go Resolves target DON nodes and checks job acceptance.
deployment/​cre/​capabilities_registry/​v2/​changeset/​job_acceptance_gate.go Implements shared JD lookup and proposal-status checks.
deployment/​cre/​capabilities_registry/​v2/​changeset/​job_acceptance_gate_test.go Tests gate behavior and changeset integration.
deployment/​cre/​capabilities_registry/​v2/​changeset/​configure_capabilities_registry.go Checks nodes supplied directly or through new DONs.

Review effort: Balanced

russell-stern
russell-stern previously approved these changes Nov 13, 2026
@justinkaseman justinkaseman changed the title (feat): Job acceptance gate for CapReg changesets (feat): Signer-family job check for CapReg changesets Nov 20, 2026
@justinkaseman
justinkaseman requested review from russell-stern and a balanced review from Copilot November 20, 2026 00:59
@justinkaseman

Copy link
Copy Markdown
Contributor Author

@russell-stern I reworked this to simplify. Matching on job name was brittle. Only enforcing for new chain families, which what was the problem before. See new description.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The gate can approve unsupported signer configurations by merging coverage across separate jobs and validating replacement peers while config generation still uses the current peers.

2 open issues
3 resolved since last review

Review effort: Balanced

return err
}

if len(nodes) == 0 {
Comment on lines +262 to +266
for f := range consensusSpecFamilies(p.Spec) {
if covered[node] == nil {
covered[node] = map[string]bool{}
}
covered[node][f] = true

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants