Repository navigation
(feat): Signer-family job check for CapReg changesets - #24166
justinkaseman wants to merge 2 commits into
Conversation
|
👋 justinkaseman, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
|
✅ No conflicts with other open PRs targeting |
There was a problem hiding this comment.
🟡 Changes recommended
The job acceptance gate can miss blocking jobs for duplicate or unnormalized peer IDs, while the truncated DON lookup can incorrectly block updates beyond the first 32 records.
3 open issues
What changed in this PR
Adds a job-acceptance gate to capabilities registry changesets to prevent configuration changes before node operators accept updated job specifications.
Changes:
- Checks target nodes’ latest job proposals in JD, blocking proposed, pending, or rejected proposals.
- Adds an explicit bypass and skips nodes not found in JD.
- Adds tests for proposal statuses, lookup behavior, errors, and bypass handling.
| File | Description |
|---|---|
| deployment/cre/capabilities_registry/v2/changeset/update_nodes_changeset.go | Gates node updates on job acceptance. |
| deployment/cre/capabilities_registry/v2/changeset/update_don.go | Resolves target DON nodes and checks job acceptance. |
| deployment/cre/capabilities_registry/v2/changeset/job_acceptance_gate.go | Implements shared JD lookup and proposal-status checks. |
| deployment/cre/capabilities_registry/v2/changeset/job_acceptance_gate_test.go | Tests gate behavior and changeset integration. |
| deployment/cre/capabilities_registry/v2/changeset/configure_capabilities_registry.go | Checks nodes supplied directly or through new DONs. |
Review effort: Balanced
961a169 to
94e44d6
Compare
|
@russell-stern I reworked this to simplify. Matching on job name was brittle. Only enforcing for new chain families, which what was the problem before. See new description. |
There was a problem hiding this comment.
🟡 Changes recommended
The gate can approve unsupported signer configurations by merging coverage across separate jobs and validating replacement peers while config generation still uses the current peers.
2 open issues
3 resolved since last review
Review effort: Balanced
| return err | ||
| } | ||
|
|
||
| if len(nodes) == 0 { |
| for f := range consensusSpecFamilies(p.Spec) { | ||
| if covered[node] == nil { | ||
| covered[node] = map[string]bool{} | ||
| } | ||
| covered[node][f] = true |


Blocks
UpdateDON,AddCapabilitiesandConfigureCapabilitiesRegistrywhen they addextraSignerFamiliesto an OCR3 config before every node has an APPROVED consensus job with a key bundle for each requested family (INCIDENT-2694).commandends inconsensus, with bundles underonchainSigningStrategy.config.skipSignerFamilyJobCheckbypasses it on all three inputs.UpdateDONandAddCapabilitiesresolve DONs by name, so DONs beyond the first 32 are covered.Limits: the check runs at proposal time, not MCMS execution, and APPROVED does not prove the node is running the job.
Follow-up in chainlink-deployments: resolver passthrough for the new flag and a
go.modbump.