Skip to content

(enhancement) Token transfer balance update verification - #361

Open
faisal-chainlink wants to merge 2 commits into
mainfrom
enhancement/tt-balance-update-verification
Open

(enhancement) Token transfer balance update verification#361
faisal-chainlink wants to merge 2 commits into
mainfrom
enhancement/tt-balance-update-verification

Conversation

@faisal-chainlink

@faisal-chainlink faisal-chainlink commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Soroban Contract Test Coverage

94.99% line coverage — 33235 / 34988 lines hit

Metric Hit Total Coverage
Lines 33235 34988 94.99%
Functions 2114 2480 85.24%
Regions 61270 64117 95.56%

Per-Contract Breakdown

Contract Lines (Hit / Total) Line Cov Funcs (Hit / Total) Func Cov
other 33235 / 34988 95.0% 2114 / 2480 85.2%
Full file-level coverage report 
Filename                                                   Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
bnm-token/src/lib.rs                                           502                65    87.05%          39                 7    82.05%         308                32    89.61%           0                 0         -
bnm-token/src/test.rs                                         1120                 0   100.00%          31                 0   100.00%         492                 0   100.00%           0                 0         -
ccip-ramp-registry/src/lib.rs                                  188                75    60.11%           8                 3    62.50%         104                41    60.58%           0                 0         -
ccip-ramp-registry/src/test.rs                                 315                 4    98.73%           8                 0   100.00%         171                 4    97.66%           0                 0         -
ccip-ramp-registry/src/types.rs                                 83                11    86.75%          17                 6    64.71%          83                11    86.75%           0                 0         -
ccvs/committee-verifier/src/lib.rs                             597                63    89.45%          28                 2    92.86%         403                18    95.53%           0                 0         -
ccvs/committee-verifier/src/test.rs                           2214                29    98.69%          81                 2    97.53%        1101                17    98.46%           0                 0         -
ccvs/committee-verifier/src/types.rs                            17                 8    52.94%           6                 5    16.67%          14                 7    50.00%           0                 0         -
ccvs/versioned-verifier-resolver/src/lib.rs                    282                21    92.55%          13                 1    92.31%         156                 4    97.44%           0                 0         -
ccvs/versioned-verifier-resolver/src/test.rs                   801                13    98.38%          25                 0   100.00%         412                 7    98.30%           0                 0         -
ccvs/versioned-verifier-resolver/src/types.rs                   89                 6    93.26%          16                 4    75.00%          83                 4    95.18%           0                 0         -
common/authorization/src/allowlist.rs                          222                33    85.14%          13                 5    61.54%         145                32    77.93%           0                 0         -
common/authorization/src/lib.rs                                426                27    93.66%          16                 0   100.00%         277                16    94.22%           0                 0         -
common/authorization/src/ownable.rs                             92                 3    96.74%           8                 0   100.00%          57                 1    98.25%           0                 0         -
common/authorization/src/test.rs                              1195                 0   100.00%          57                 0   100.00%         462                 0   100.00%           0                 0         -
common/authorization/src/upgradeable.rs                         13                 1    92.31%           1                 0   100.00%           7                 0   100.00%           0                 0         -
common/guard/src/initializable.rs                               30                 1    96.67%           4                 0   100.00%          22                 1    95.45%           0                 0         -
common/guard/src/lib.rs                                         32                 1    96.88%           4                 0   100.00%          22                 0   100.00%           0                 0         -
common/guard/src/test.rs                                       101                 0   100.00%           8                 0   100.00%          47                 0   100.00%           0                 0         -
common/helpers/src/curse_checkable.rs                          111                25    77.48%           6                 1    83.33%          60                12    80.00%           0                 0         -
common/helpers/src/fee_math.rs                                 421                 2    99.52%          30                 0   100.00%         244                 1    99.59%           0                 0         -
common/helpers/src/finality_codec.rs                            52                 0   100.00%           3                 0   100.00%          41                 0   100.00%           0                 0         -
common/helpers/src/map_updater.rs                               94                15    84.04%           7                 3    57.14%          39                 8    79.49%           0                 0         -
common/helpers/src/soroban_invoke.rs                           277                 7    97.47%          12                 0   100.00%         115                 1    99.13%           0                 0         -
common/helpers/src/validation.rs                                75                 0   100.00%           4                 0   100.00%          41                 0   100.00%           0                 0         -
common/helpers/src/verifier_versioning.rs                       45                 3    93.33%           3                 0   100.00%          32                 2    93.75%           0                 0         -
common/interfaces/src/advanced_pool_hooks.rs                     6                 6     0.00%           6                 6     0.00%           6                 6     0.00%           0                 0         -
common/interfaces/src/advanced_pool_hooks_extractor.rs           9                 9     0.00%           9                 9     0.00%           9                 9     0.00%           0                 0         -
common/interfaces/src/ccip_receiver.rs                           6                 6     0.00%           6                 6     0.00%           6                 6     0.00%           0                 0         -
common/interfaces/src/committee_verifier.rs                      6                 6     0.00%           6                 6     0.00%           6                 6     0.00%           0                 0         -
common/interfaces/src/executor.rs                                3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
common/interfaces/src/fee_quoter.rs                             13                13     0.00%          13                13     0.00%          13                13     0.00%           0                 0         -
common/interfaces/src/offramp.rs                                 4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
common/interfaces/src/onramp.rs                                  4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
common/interfaces/src/policy_engine.rs                           5                 5     0.00%           5                 5     0.00%           5                 5     0.00%           0                 0         -
common/interfaces/src/pool_hooks.rs                              3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
common/interfaces/src/ramp_registry.rs                           4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
common/interfaces/src/router.rs                                  6                 6     0.00%           6                 6     0.00%           6                 6     0.00%           0                 0         -
common/interfaces/src/siloed_lock_release_pool.rs               14                14     0.00%          14                14     0.00%          14                14     0.00%           0                 0         -
common/interfaces/src/token_admin_registry.rs                    1                 1     0.00%           1                 1     0.00%           1                 1     0.00%           0                 0         -
common/interfaces/src/token_pool.rs                             13                13     0.00%          13                13     0.00%          13                13     0.00%           0                 0         -
common/interfaces/src/versioned_verifier_resolver.rs             4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
common/message/src/lib.rs                                      676                50    92.60%          34                 4    88.24%         334                 9    97.31%           0                 0         -
common/message/src/test.rs                                     999                10    99.00%          42                 0   100.00%         496                 0   100.00%           0                 0         -
common/pool/src/decimals.rs                                    109                10    90.83%           6                 0   100.00%          76                 3    96.05%           0                 0         -
common/pool/src/lib.rs                                         774                58    92.51%          43                 1    97.67%         658                36    94.53%           0                 0         -
common/pool/src/rate_limit.rs                                  180                 2    98.89%           9                 0   100.00%         145                 1    99.31%           0                 0         -
common/pool/src/types.rs                                        25                16    36.00%          19                16    15.79%          43                16    62.79%           0                 0         -
common/signature/src/config.rs                                  44                12    72.73%           6                 2    66.67%          28                 5    82.14%           0                 0         -
common/signature/src/quorum.rs                                  68                 1    98.53%           2                 0   100.00%          44                 1    97.73%           0                 0         -
common/signature/src/scheme.rs                                  45                 0   100.00%           2                 0   100.00%          29                 0   100.00%           0                 0         -
cre/forwarder/src/error.rs                                       8                 3    62.50%           1                 0   100.00%           8                 3    62.50%           0                 0         -
cre/forwarder/src/lib.rs                                       597                22    96.31%          26                 0   100.00%         417                 4    99.04%           0                 0         -
cre/forwarder/src/test.rs                                     3426                14    99.59%         151                 2    98.68%        1430                 8    99.44%           0                 0         -
cre/forwarder/src/types.rs                                      62                 6    90.32%          10                 6    40.00%          36                 6    83.33%           0                 0         -
cre/mock_forwarder/src/lib.rs                                  119                 4    96.64%           6                 0   100.00%         100                 2    98.00%           0                 0         -
cre/mock_forwarder/src/test.rs                                 461                 3    99.35%          23                 1    95.65%         286                 3    98.95%           0                 0         -
cre/mock_forwarder/src/types.rs                                 36                 5    86.11%           7                 5    28.57%          23                 5    78.26%           0                 0         -
cre/test/read_fixture/src/lib.rs                               125               125     0.00%          33                33     0.00%         103               103     0.00%           0                 0         -
cre/test/receiver/src/lib.rs                                    53                53     0.00%           5                 5     0.00%          26                26     0.00%           0                 0         -
cre/test/rejecting_receiver/src/lib.rs                           3                 3     0.00%           1                 1     0.00%           8                 8     0.00%           0                 0         -
executor/src/lib.rs                                            371                35    90.57%          14                 0   100.00%         258                15    94.19%           0                 0         -
executor/src/test.rs                                          1086                 9    99.17%          35                 1    97.14%         482                 8    98.34%           0                 0         -
executor/src/types.rs                                            9                 3    66.67%           4                 3    25.00%           9                 3    66.67%           0                 0         -
fee-quoter/src/lib.rs                                          761               148    80.55%          22                 3    86.36%         529                90    82.99%           0                 0         -
fee-quoter/src/test.rs                                        1592                 4    99.75%          29                 0   100.00%         800                 4    99.50%           0                 0         -
fee-quoter/src/types.rs                                         14                14     0.00%          14                14     0.00%          14                14     0.00%           0                 0         -
link-token/src/lib.rs                                          494                65    86.84%          38                 7    81.58%         300                32    89.33%           0                 0         -
link-token/src/test.rs                                        1050                 0   100.00%          29                 0   100.00%         468                 0   100.00%           0                 0         -
mcms/src/constants.rs                                           10                 0   100.00%           2                 0   100.00%           6                 0   100.00%           0                 0         -
mcms/src/crypto.rs                                             202                 3    98.51%           7                 0   100.00%         109                 2    98.17%           0                 0         -
mcms/src/encoding.rs                                           328                 8    97.56%          15                 0   100.00%         196                 3    98.47%           0                 0         -
mcms/src/error.rs                                                8                 3    62.50%           1                 0   100.00%           8                 3    62.50%           0                 0         -
mcms/src/lib.rs                                                746                54    92.76%          18                 0   100.00%         523                23    95.60%           0                 0         -
mcms/src/test.rs                                              2857                43    98.49%          82                 2    97.56%        1347                20    98.52%           0                 0         -
mcms/src/types.rs                                               10                10     0.00%          10                10     0.00%          10                10     0.00%           0                 0         -
offramp/src/lib.rs                                            1172               133    88.65%          40                 2    95.00%         754                62    91.78%           0                 0         -
offramp/src/test.rs                                           4539                40    99.12%         110                 1    99.09%        1997                26    98.70%           0                 0         -
offramp/src/types.rs                                            33                 6    81.82%           7                 5    28.57%          27                 6    77.78%           0                 0         -
onramp/src/lib.rs                                             1439               126    91.24%          33                 2    93.94%         928                48    94.83%           0                 0         -
onramp/src/test.rs                                            6325                27    99.57%         170                 4    97.65%        3477                37    98.94%           0                 0         -
onramp/src/types.rs                                             28                 9    67.86%           6                 5    16.67%          24                 7    70.83%           0                 0         -
pools/advanced-pool-hooks-extractor/src/lib.rs                 101                 1    99.01%           4                 0   100.00%          98                 1    98.98%           0                 0         -
pools/advanced-pool-hooks-extractor/src/test.rs                324                11    96.60%          15                 1    93.33%         183                 9    95.08%           0                 0         -
pools/advanced-pool-hooks/src/lib.rs                           620                39    93.71%          26                 0   100.00%         460                16    96.52%           0                 0         -
pools/advanced-pool-hooks/src/test.rs                         2164                43    98.01%          82                 4    95.12%        1021                35    96.57%           0                 0         -
pools/advanced-pool-hooks/src/types.rs                          36                 3    91.67%           4                 2    50.00%          35                 3    91.43%           0                 0         -
pools/burn-mint-pool/src/lib.rs                                530                86    83.77%          38                 6    84.21%         399                30    92.48%           0                 0         -
pools/burn-mint-pool/src/test.rs                              5134                38    99.26%         118                 7    94.07%        3241                87    97.32%           0                 0         -
pools/lock-release-pool/src/lib.rs                             612               141    76.96%          41                13    68.29%         444                63    85.81%           0                 0         -
pools/lock-release-pool/src/test.rs                           3484                38    98.91%          82                 7    91.46%        2171                87    95.99%           0                 0         -
pools/siloed-lock-release-pool/src/lib.rs                      689               220    68.07%          47                20    57.45%         497               136    72.64%           0                 0         -
pools/siloed-lock-release-pool/src/test.rs                    2071                26    98.74%          64                 4    93.75%        1194                49    95.90%           0                 0         -
pools/token-lock-box/src/lib.rs                                197                17    91.37%          13                 1    92.31%         113                 2    98.23%           0                 0         -
pools/token-lock-box/src/test.rs                               356                 4    98.88%          10                 0   100.00%         114                 4    96.49%           0                 0         -
registry/src/lib.rs                                              8                 0   100.00%           1                 0   100.00%           3                 0   100.00%           0                 0         -
registry/src/test.rs                                            27                 0   100.00%           1                 0   100.00%          11                 0   100.00%           0                 0         -
rmn_proxy/src/lib.rs                                            99                13    86.87%           6                 1    83.33%          50                 3    94.00%           0                 0         -
rmn_proxy/src/test.rs                                          570                 4    99.30%          18                 0   100.00%         181                 4    97.79%           0                 0         -
rmn_remote/src/lib.rs                                          302                25    91.72%          16                 1    93.75%         171                 9    94.74%           0                 0         -
rmn_remote/src/test.rs                                         480                 4    99.17%          17                 0   100.00%         172                 4    97.67%           0                 0         -
router/src/lib.rs                                              632                89    85.92%          19                 1    94.74%         394                43    89.09%           0                 0         -
router/src/test.rs                                            1439                 4    99.72%          36                 0   100.00%         612                 4    99.35%           0                 0         -
router/src/test_panic_receiver.rs                                5                 0   100.00%           2                 0   100.00%           5                 0   100.00%           0                 0         -
router/src/types.rs                                              3                 3     0.00%           3                 3     0.00%           3                 3     0.00%           0                 0         -
timelock/src/encoding.rs                                       329                 3    99.09%          15                 0   100.00%         182                 1    99.45%           0                 0         -
timelock/src/error.rs                                            6                 2    66.67%           1                 0   100.00%           6                 2    66.67%           0                 0         -
timelock/src/lib.rs                                            713               258    63.81%          35                11    68.57%         401               130    67.58%           0                 0         -
timelock/src/roles.rs                                           82                24    70.73%           7                 1    85.71%          62                18    70.97%           0                 0         -
timelock/src/storage.rs                                        233                51    78.11%          14                 1    92.86%         124                22    82.26%           0                 0         -
timelock/src/test.rs                                          1050                17    98.38%          31                 0   100.00%         410                 3    99.27%           0                 0         -
timelock/src/types.rs                                            4                 4     0.00%           4                 4     0.00%           4                 4     0.00%           0                 0         -
token-admin-registry/src/lib.rs                                384                22    94.27%          18                 1    94.44%         258                 3    98.84%           0                 0         -
token-admin-registry/src/test.rs                              1052                 4    99.62%          29                 0   100.00%         372                 4    98.92%           0                 0         -
token-admin-registry/src/types.rs                                2                 2     0.00%           2                 2     0.00%           2                 2     0.00%           0                 0         -
----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                        64117              2847    95.56%        2480               366    85.24%       34988              1753    94.99%           0                 0         -```

</details>

> Commit `30d653d0` | [Full CI run](https://github.com/smartcontractkit/chainlink-stellar/actions/runs/42056683236)

<!-- Sticky Pull Request Commentcontract-coverage -->

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Code coverage report:

Top package main enhancement/tt-balance-update-verification diff
github.com/smartcontractkit/chainlink-stellar/cmd 0.00% 0.00% +0.00%

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Integration Test Coverage

total:														(statements)				11.9%

Full coverage report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FelixFan1992 FelixFan1992 Awaiting requested review from FelixFan1992
@JohnChangUK JohnChangUK Awaiting requested review from JohnChangUK

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@faisal-chainlink