Skip to content

DF-23700 fix scale of latency for beholder + cleanups - #104

Merged
vlfig merged 1 commit into
mainfrom
fix-latency-scale
Apr 23, 2026
Merged

vlfig merged 1 commit into
mainfrom
fix-latency-scale

Conversation

@vlfig

@vlfig vlfig commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Description

Divides the latency Duration value by time.Milliseconds for the beholder latency histogram.

Cleans up implementation a bit.

Why

Metrics are coming in all in the "+Inf" bucket. All 13162 of them.

    sum(rpc_call_latency_bucket{service_version="2.43.0", le!="+Inf"}) by (le) > 0
    count(rpc_call_latency_bucket{service_version="2.43.0", le!="+Inf"}) by (le) > 0

The default buckets, as used for the beholder histogram, are good for milliseconds so that's the idiom we're following.

Requires Dependencies

Resolves Dependencies

@github-actions

This comment was marked as outdated.

@vlfig
vlfig marked this pull request as ready for review April 21, 2026 13:57
@vlfig
vlfig requested a review from a team as a code owner April 21, 2026 13:57
@vlfig
vlfig force-pushed the fix-latency-scale branch from 7745fce to e2b945d Compare April 21, 2026 15:53
ilija42
ilija42 previously approved these changes Apr 22, 2026
silaslenihan
silaslenihan previously approved these changes Apr 22, 2026
@vlfig
vlfig dismissed stale reviews from silaslenihan and ilija42 via 5a9f3fb April 23, 2026 09:36
Default buckets are good for milliseconds.
@vlfig
vlfig force-pushed the fix-latency-scale branch from 5a9f3fb to d8e99e9 Compare April 23, 2026 09:38
@vlfig

vlfig commented Apr 23, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, @ilija42 and @silaslenihan a conflict forced me to dismiss your reviews.

@vlfig
vlfig merged commit 5b1a756 into main Apr 23, 2026
24 checks passed
@vlfig
vlfig deleted the fix-latency-scale branch April 23, 2026 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants