Repository navigation
OEV-1803 Remove Meter() TODO post core bump - #600
Merged
Merged
Conversation
Make legacyevm.ChainOpts.Meter required and drop the beholder.GetMeter() fallback in newChain. Core now passes the meter explicitly.
Contributor
|
👋 mostlyconsistent, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
📊 API Diff Results
|
jmank88
approved these changes
Nov 16, 2026
mostlyconsistent
enabled auto-merge (squash)
November 18, 2026 18:20
dimriou
approved these changes
Nov 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes
legacyevm.ChainOpts.Meterrequired and drops thebeholder.GetMeter()fallback innewChain.Jira: OEV-1803
Background
evm_chain_config_infoand introduced a temporary fallback to the global beholder meter, because chainlink core did not yet pass aMeter. It was marked with a TODO to make the field required once core wired it explicitly.Meter: beholder.GetMeter()explicitly inapplication.go.Changes
pkg/chains/legacyevm/chain.goChainOpts.Meteras required and remove the TODO.nil Metercheck toChainOpts.Validate().beholder.GetMeter()fallback innewChainand the unusedbeholderimport.pkg/chains/legacyevm/chain_test.goMeterin the validChainOptscase.Testing
go test ./pkg/chains/legacyevm/ -run TestChainOpts_Validatego build ./pkg/chains/...Notes
Any caller that builds
ChainOptswithout aMeterwill now fail validation instead of silently using the global meter.