Skip to content

OEV-1803 Remove Meter() TODO post core bump - #600

Merged
mostlyconsistent merged 2 commits into
developfrom
mkysel/remove-meter-todo-v2
Nov 19, 2026
Merged

mostlyconsistent merged 2 commits into
developfrom
mkysel/remove-meter-todo-v2

Conversation

@mostlyconsistent

@mostlyconsistent mostlyconsistent commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Makes legacyevm.ChainOpts.Meter required and drops the beholder.GetMeter() fallback in newChain.

Jira: OEV-1803

Background

Changes

  • pkg/chains/legacyevm/chain.go
    • Document ChainOpts.Meter as required and remove the TODO.
    • Add a nil Meter check to ChainOpts.Validate().
    • Remove the beholder.GetMeter() fallback in newChain and the unused beholder import.
  • pkg/chains/legacyevm/chain_test.go
    • Set Meter in the valid ChainOpts case.
    • Add a "missing meter" case that expects a validation error.

Testing

  • go test ./pkg/chains/legacyevm/ -run TestChainOpts_Validate
  • go build ./pkg/chains/...

Notes

Any caller that builds ChainOpts without a Meter will now fail validation instead of silently using the global meter.

Make legacyevm.ChainOpts.Meter required and drop the beholder.GetMeter()
fallback in newChain. Core now passes the meter explicitly.
@github-actions

Copy link
Copy Markdown
Contributor

👋 mostlyconsistent, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

📊 API Diff Results

No changes detected for module github.com/smartcontractkit/chainlink-evm

View full report

@mostlyconsistent
mostlyconsistent enabled auto-merge (squash) November 18, 2026 18:20
@mostlyconsistent
mostlyconsistent merged commit d4ad5a3 into develop Nov 19, 2026
36 checks passed
@mostlyconsistent
mostlyconsistent deleted the mkysel/remove-meter-todo-v2 branch November 19, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants