Repository navigation
Potential fix for code scanning alert no. 72: Code injection - #593
Merged
Merged
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
jmank88
requested review from
Oozyx,
RayXpub,
bolekk,
bryan-maxwell,
chainchad,
elatoskinas and
matYang
November 10, 2026 22:33
jmank88
marked this pull request as ready for review
November 10, 2026 22:35
erikburt
approved these changes
Nov 10, 2026
jmank88
enabled auto-merge (squash)
November 10, 2026 22:42
chainchad
approved these changes
Nov 10, 2026
kalverra
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/smartcontractkit/chainlink-evm/security/code-scanning/72
Use the recommended safe pattern for GitHub Actions shell steps: pass expression values through
env:and then reference them in bash as"$VAR"(never${{ env.VAR }}insiderun:). This prevents expression-time injection into the script body.Best minimal fix in
.github/workflows/solidity-foundry-artifacts.yml:Transform modified filesstep, add env mappings for:CHANGES_PRODUCTCHANGES_PRODUCT_FILESCHANGES_OTHER_SHAREDCHANGES_OTHER_SHARED_FILES${{ steps.changes-dorny.outputs.* }}usages insiderun:with quoted shell variables ("$CHANGES_PRODUCT_FILES", etc.), including line 109 and related lines/conditions.Suggested fixes powered by Copilot Autofix. Review carefully before merging.