Repository navigation
Conversation
Contributor
📊 API Diff Results
|
j-nowak
force-pushed
the
l1-logpoller-batch-tests-metrics
branch
2 times, most recently
from
November 10, 2026 09:38
538ff3f to
571a065
Compare
j-nowak
force-pushed
the
l1-logpoller-batch-tests-metrics
branch
from
November 10, 2026 09:42
571a065 to
42aeddb
Compare
j-nowak
force-pushed
the
l1-logpoller-batch-tests-metrics
branch
from
November 10, 2026 09:45
42aeddb to
e107c83
Compare
j-nowak
force-pushed
the
l1-logpoller-batch-tests-metrics
branch
2 times, most recently
from
November 10, 2026 10:24
cde7616 to
9b8478d
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new batch tests query logs without registered filters instead of checking stored blocks, leaving hash validation empty and allowing stale or orphaned block rows to go undetected.
1 open issue
What changed in this PR
Adds integration/property coverage and operational metrics for the opt-in batched unfinalized-block walk introduced in #590. The feature remains disabled by default.
Changes:
- Extends geth synchronization tests to batch mode with both empty-block settings, using 25 iterations per batch variant.
- Records batch chunk outcomes, durations, and walked-header counts.
- Refines error-type assertions, flag-off checks, and integer-conversion lint annotations.
| File | Description |
|---|---|
pkg/logpoller/unfinalized_batch.go |
Records metrics across successful, partial, reorg, and error exits. |
pkg/logpoller/unfinalized_batch_internal_test.go |
Improves error assertions, flag-off checks, and conversion annotations. |
pkg/logpoller/metrics.go |
Defines batch outcome, duration, and header-count metrics. |
pkg/logpoller/log_poller_test.go |
Adds batch-mode variants to the geth synchronization property test. |
Review effort: Balanced
Comment on lines
+747
to
+748
| BatchUnfinalizedBlocks: tc.batchUnfinalizedBlocks, | ||
| BatchUnfinalizedBlocksChunkSize: 3, |
j-nowak
force-pushed
the
l1-logpoller-batch-tests-metrics
branch
from
November 10, 2026 11:08
9b8478d to
9429c69
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Context
Stacked on #590. This is PR 3 of the L1 stack: integration/property coverage and operational metrics for the opt-in batched unfinalized walk. The feature remains disabled by default.
What changed
TestLogPoller_SynchronizedWithGethto run the batch path with bothskipEmptyBlockssettings. The batch variants use 25 gopter iterations to keep CI time bounded; the legacy variants keep 100.evm_log_poller_unfinalized_batch_chunks_total{chainID,outcome}with outcomessuccess,partial,reorg,error;evm_log_poller_unfinalized_batch_duration_seconds{chainID};evm_log_poller_unfinalized_batch_headers_total{chainID}.evm_log_poller_last_processed_blockmetric as the primary lag signal.Why these metrics
BatchCallContextrecords oneevm_pool_rpc_node_calls_totalincrement for the whole header batch, not one per header, so existing header-call dashboards undercount in batch mode. The new metrics make the opt-in path observable during the canary without changing existing dashboards. The legacy path does not record them.Testing
go test -short ./pkg/logpoller/...passes.CL_DATABASE_URL.CL_DATABASE_URL=... go test -race -run 'TestGetUnfinalizedLogsBatched|TestGetUnfinalizedLogsForMode|TestLogPoller_SynchronizedWithGeth' ./pkg/logpoller.CI is green: check-tidy, golangci-lint, Build Chainlink, and the full
go test -race ./...matrix (including DB-backed tests).Safety
Stack