Repository navigation
DS-4344 Updates for per digest PDAs and verification - #3
Open
justinfranco wants to merge 4 commits into
Open
justinfranco wants to merge 4 commits into
justinfranco wants to merge 4 commits into
Conversation
|
Thank you for adding a CODEOWNERS file - @justinfranco. |
There was a problem hiding this comment.
🔵 Needs a closer look
Security-critical configuration selection and upgrade compatibility require final human review, with a remaining signer-isolation test gap.
1 open issue
9 files not reviewed
client/go/verifier/ActivateConfig.go: Generated fileclient/go/verifier/CloseConfig.go: Generated fileclient/go/verifier/DeactivateConfig.go: Generated fileclient/go/verifier/DeactivateConfig_test.go: Generated fileclient/go/verifier/SetConfig.go: Generated fileclient/go/verifier/UpdateConfig.go: Generated fileclient/go/verifier/UpdateConfig_test.go: Generated fileclient/go/verifier/accounts.go: Generated fileclient/go/verifier/instructions.go: Generated file
What changed in this PR
Migrates the Solana verifier to per-digest DON configurations, enabling concurrent verification across multiple DONs while preserving the verification interface.
Changes:
- Adds digest-specific configuration management and optional legacy fallback.
- Hardens report-offset parsing and expands verification tests.
- Updates documentation, IDL, and Go bindings for v0.5.0.
| File | Description |
|---|---|
| test_utils/src/report.rs | Adds digest-aware report generation. |
| test_utils/src/client/verifier_client.rs | Supports new instructions and legacy fixtures. |
| test_utils/Cargo.toml | Adds account-data utility dependency. |
| target/idl/verifier.json | Updates instructions, accounts, events, and errors. |
| programs/verifier/tests/verifier_verify_test.rs | Tests digest verification and SDK compatibility. |
| programs/verifier/tests/verifier_update_config_test.rs | Tests configuration updates. |
| programs/verifier/tests/verifier_set_config_with_activation_time_test.rs | Removes obsolete setter tests. |
| programs/verifier/tests/verifier_set_config_test.rs | Tests digest configuration creation. |
| programs/verifier/tests/verifier_set_config_active_test.rs | Removes legacy activation tests. |
| programs/verifier/tests/verifier_remove_latest_config_test.rs | Removes legacy removal tests. |
| programs/verifier/tests/verifier_legacy_fallback_test.rs | Tests legacy fallback behavior. |
| programs/verifier/tests/verifier_close_config_test.rs | Tests closure and rent refunds. |
| programs/verifier/tests/verifier_activate_config_test.rs | Tests activation and deactivation. |
| programs/verifier/tests/common/mod.rs | Exports shared fixtures. |
| programs/verifier/tests/common/fixtures.rs | Centralizes signed-report fixtures. |
| programs/verifier/src/state/verifier_account.rs | Adds layout-preserving fallback flag. |
| programs/verifier/src/state/mod.rs | Exports digest configuration state. |
| programs/verifier/src/state/digest_config.rs | Defines per-digest configuration accounts. |
| programs/verifier/src/lib.rs | Implements configuration management and lookup. |
| programs/verifier/src/evm/signature_test.rs | Adds signature recovery tests. |
| programs/verifier/src/evm/encoding.rs | Guards offset overflow; removes legacy helpers. |
| programs/verifier/src/evm/encoding_test.rs | Adds report parsing tests. |
| programs/verifier/src/events.rs | Defines digest configuration events. |
| programs/verifier/src/errors.rs | Appends digest-specific errors. |
| programs/verifier/src/context/update_digest_config_context.rs | Constrains configuration updates. |
| programs/verifier/src/context/set_config_context.rs | Constrains configuration creation. |
| programs/verifier/src/context/mod.rs | Exports new instruction contexts. |
| programs/verifier/src/context/close_config_context.rs | Constrains configuration closure. |
| programs/verifier/README.md | Documents configuration management and migration. |
| programs/verifier/Cargo.toml | Bumps version and adds SDK testing dependency. |
| programs/verifier/Cargo.lock | Updates verifier version. |
| client/go/verifier/UpdateConfig.go | Adds update instruction binding. |
| client/go/verifier/UpdateConfig_test.go | Tests update serialization. |
| client/go/verifier/SetLegacyFallback.go | Adds fallback instruction binding. |
| client/go/verifier/SetLegacyFallback_test.go | Tests fallback serialization. |
| client/go/verifier/SetConfigWithActivationTime.go | Removes legacy setter binding. |
| client/go/verifier/SetConfigActive.go | Removes legacy activation binding. |
| client/go/verifier/SetConfig.go | Updates digest-based creation binding. |
| client/go/verifier/instructions.go | Registers new instruction variants. |
| client/go/verifier/DeactivateConfig.go | Adds deactivation binding. |
| client/go/verifier/DeactivateConfig_test.go | Tests deactivation serialization. |
| client/go/verifier/CloseConfig.go | Adds closure binding. |
| client/go/verifier/CloseConfig_test.go | Tests closure serialization. |
| client/go/verifier/ActivateConfig.go | Adds activation binding. |
| client/go/verifier/ActivateConfig_test.go | Tests activation serialization. |
| client/go/verifier/accounts.go | Updates account serialization. |
| Cargo.lock | Records version and dependency changes. |
Review effort: Balanced
justinfranco
marked this pull request as ready for review
November 4, 2026 18:34
akuzni2
reviewed
Nov 4, 2026
akuzni2
reviewed
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Verifier v0.5.0: per-digest DON configs (DS-4344)
Moves the Solana verifier to the v0.5.0 config model used by EVM (v0.5.0+). DON configs are stored per config digest in their own PDA (
[config_digest]), so reports from multiple DONs (e.g. DON 3 and DON 4) can be verified at the same time.Customer impact
None.
verifyis unchanged: same program ID, instruction data, accounts, return data,ReportVerifiedevent, error codes and> fsignature rule. Integrators already pass the config PDA derived from the report digest.Changes
New config instructions (owner only):
set_config(config_digest, signers, f),update_config,activate_config,deactivate_config,close_config.New
DigestConfigaccount per digest. All configs can be listed withgetProgramAccountsfiltered by its discriminator.Verify lookup order:
legacy config fallback);set_legacy_fallback(false),DigestNotSet.A deactivated digest config never falls back.
Removed the legacy setters:
set_config_with_activation_time,set_config_active,remove_latest_config. Existing legacy configs stay read-only inVerifierAccount.New errors (appended):
DigestEmpty,DigestNotSet,ConfigDigestAlreadySet. New events:ConfigSet,ConfigUpdated,ConfigActivated,ConfigDeactivated,ConfigClosed,LegacyFallbackSet.Parser hardening: malformed report offsets now return
BadVerificationinstead of panicking on overflow.Regenerated: IDL and Go bindings (anchor-go v0.3.1). Breaking for Gauntlet / Go config tooling.
Tests
evm/encoding_test.rsandevm/signature_test.rsunit tests, which were declared but never committed and brokeanchor buildIDL generation andcargo test-sbf.anchor build,RUST_MIN_STACK=16777216 cargo test-sbfandgo test ./...pass.Upgrade notes