Skip to content

loopinstall: add binaryName to decouple build path from installed name - #2551

Merged
nolag merged 1 commit into
mainfrom
rtinianov_loopinstall_binaryname
Nov 16, 2026
Merged

nolag merged 1 commit into
mainfrom
rtinianov_loopinstall_binaryname

Conversation

@nolag

@nolag nolag commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Adds an optional binaryName field to loopinstall's plugin manifest (PluginDef).
  • By default the installed binary is named after the base of installPath (or moduleURI at the module root). Capabilities that moved to a layout where the package building the binary is not named after it (e.g. cron's legacy LOOP living at scheduler/cron/legacy while nodes look it up as cron) can no longer be expressed. binaryName overrides the output name while the build target stays installPath.
  • Validated as a plain file name so it cannot escape the output directory or smuggle path separators; recorded in the build manifest.
  • Needed by Update cron to the new PSB chainlink#24213 to install cron/cronv2 from the new scheduler/cron module layout.

Testing

  • go test ./pkg/loop/cmd/loopinstall/... — 62 tests pass, new cases cover the override and validation.

🤖 Generated with Claude Code

@nolag
nolag requested a review from a team as a code owner November 16, 2026 16:37
@github-actions

Copy link
Copy Markdown
Contributor

👋 nolag, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

github-actions Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

✅ API Diff Results - github.com/smartcontractkit/chainlink-common

✅ Compatible Changes (2)

pkg/loop/cmd/loopinstall.PluginDef (1)
  • BinaryName — ➕ Added
pkg/loop/cmd/loopinstall.PluginManifest (1)
  • BinaryName — ➕ Added

📄 View full apidiff report

The installed binary is named after the base of installPath (or moduleURI
at the module root). Capabilities that moved to a layout where the
package building the binary is not named after it (e.g. cron's legacy
LOOP living at scheduler/cron/legacy while nodes look it up as "cron")
can no longer be expressed. Add an optional binaryName field that
overrides the output name while the build target stays installPath.

Co-Authored-By: Claude Code <noreply@anthropic.com>
@nolag
nolag force-pushed the rtinianov_loopinstall_binaryname branch from 803575a to 7a9c8e6 Compare November 16, 2026 18:01
@nolag
nolag enabled auto-merge November 16, 2026 18:01
@nolag
nolag added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 5d9da18 Nov 16, 2026
32 of 33 checks passed
@nolag
nolag deleted the rtinianov_loopinstall_binaryname branch November 16, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants