Repository navigation
loopinstall: add binaryName to decouple build path from installed name - #2551
Merged
Merged
Conversation
Contributor
|
👋 nolag, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
Contributor
✅ API Diff Results -
|
The installed binary is named after the base of installPath (or moduleURI at the module root). Capabilities that moved to a layout where the package building the binary is not named after it (e.g. cron's legacy LOOP living at scheduler/cron/legacy while nodes look it up as "cron") can no longer be expressed. Add an optional binaryName field that overrides the output name while the build target stays installPath. Co-Authored-By: Claude Code <noreply@anthropic.com>
nolag
force-pushed
the
rtinianov_loopinstall_binaryname
branch
from
November 16, 2026 18:01
803575a to
7a9c8e6
Compare
nolag
enabled auto-merge
November 16, 2026 18:01
cedric-cordenier
approved these changes
Nov 16, 2026
DylanTinianov
approved these changes
Nov 16, 2026
erikburt
approved these changes
Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
binaryNamefield to loopinstall's plugin manifest (PluginDef).installPath(ormoduleURIat the module root). Capabilities that moved to a layout where the package building the binary is not named after it (e.g. cron's legacy LOOP living atscheduler/cron/legacywhile nodes look it up ascron) can no longer be expressed.binaryNameoverrides the output name while the build target staysinstallPath.scheduler/cronmodule layout.Testing
go test ./pkg/loop/cmd/loopinstall/...— 62 tests pass, new cases cover the override and validation.🤖 Generated with Claude Code