Skip to content

Remove deprecated CapabilitiesRegistry aliases from types/core - #2545

Open
cedric-cordenier wants to merge 1 commit into
mainfrom
remove-deprecated-capreg-aliases
Open

cedric-cordenier wants to merge 1 commit into
mainfrom
remove-deprecated-capreg-aliases

Conversation

@cedric-cordenier

@cedric-cordenier cedric-cordenier commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Removes the deprecated aliases core.CapabilitiesRegistry, core.CapabilitiesRegistryMetadata and core.CapabilitiesRegistryBase. Callers should use the types in pkg/capabilities/registry directly.

  • Switches all internal callers (pkg/loop, pkg/types/core, tests).
  • Updates the capability server template (protoc/pkg/templates/server.go.tmpl) and regenerates the *_server_gen.go files. Regenerating with a freshly built protoc-gen-cre reproduces the committed output.

Downstream: the following must merge, and be bumped where they're consumed, before anything takes this change:

chainlink-evm and data-streams were checked by building them against this branch.

🤖 Generated with Claude Code

Drop core.CapabilitiesRegistry, core.CapabilitiesRegistryMetadata and
core.CapabilitiesRegistryBase in favour of the definitions in
pkg/capabilities/registry, and switch all internal callers, including the
capability server template and its generated code.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cedric-cordenier
cedric-cordenier requested review from a team as code owners November 11, 2026 12:16
Copilot AI balanced review requested due to automatic review settings November 11, 2026 12:16
@github-actions

Copy link
Copy Markdown
Contributor

👋 cedric-cordenier, thanks for creating this pull request!

To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team.

Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ API Diff Results - github.com/smartcontractkit/chainlink-common

⚠️ Breaking Changes (3)

pkg/types/core (3)
  • CapabilitiesRegistry — 🗑️ Removed

  • CapabilitiesRegistryBase — 🗑️ Removed

  • CapabilitiesRegistryMetadata — 🗑️ Removed


📄 View full apidiff report

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Removing the CapabilitiesRegistry alias leaves mockery targeting a missing type with fail-on-missing enabled, causing the CI mock-generation check to fail until the configuration and generated mocks are updated.

1 open issue
16 files not reviewed
  • pkg/capabilities/v2/actions/confidentialhttp/server/client_server_gen.go: Generated file
  • pkg/capabilities/v2/actions/confidentialworkflow/server/client_server_gen.go: Generated file
  • pkg/capabilities/v2/actions/http/server/client_server_gen.go: Generated file
  • pkg/capabilities/v2/chain-capabilities/aptos/server/client_server_gen.go: Generated file
  • pkg/capabilities/v2/chain-capabilities/evm/server/client_server_gen.go: Generated file
  • pkg/capabilities/v2/chain-capabilities/solana/server/client_server_gen.go: Generated file
  • pkg/capabilities/v2/chain-capabilities/stellar/server/client_server_gen.go: Generated file
  • pkg/capabilities/v2/consensus/server/consensus_server_gen.go: Generated file
  • pkg/capabilities/v2/protoc/pkg/test_capabilities/actionandtrigger/server/action_and_trigger_server_gen.go: Generated file
  • pkg/capabilities/v2/protoc/pkg/test_capabilities/basicaction/server/basic_action_server_gen.go: Generated file
  • pkg/capabilities/v2/protoc/pkg/test_capabilities/basictrigger/server/basic_trigger_server_gen.go: Generated file
  • pkg/capabilities/v2/protoc/pkg/test_capabilities/consensus/server/consensus_server_gen.go: Generated file
  • pkg/capabilities/v2/protoc/pkg/test_capabilities/importclash/server/clash_server_gen.go: Generated file
  • pkg/capabilities/v2/protoc/pkg/test_capabilities/nodeaction/server/node_action_server_gen.go: Generated file
  • pkg/capabilities/v2/triggers/cron/server/trigger_server_gen.go: Generated file
  • pkg/capabilities/v2/triggers/http/server/trigger_server_gen.go: Generated file
What changed in this PR

Removes the deprecated capability registry aliases from pkg/types/core and migrates internal callers to pkg/capabilities/registry. Downstream consumers using the removed aliases must migrate before upgrading.

Changes:

  • Deletes the three deprecated registry aliases.
  • Updates LOOP interfaces, implementations, and tests to use registry types directly.
  • Updates the capability server template and regenerated servers.
File Description
pkg/​types/​core/​standard_capabilities_dependencies.go Uses the registry type for capability dependencies.
pkg/​types/​core/​reporting_plugin_service.go Updates OCR3 interface signatures.
pkg/​types/​core/​capabilities_registry.go Removes the three deprecated aliases.
pkg/​loop/​reportingplugins/​ocr3/​loopp_service.go Updates the service constructor parameter.
pkg/​loop/​reportingplugins/​ocr3/​loopp_service_test.go Updates registry arguments in service tests.
pkg/​loop/​reportingplugins/​ocr3/​grpc.go Updates registry parameters in gRPC adapters.
pkg/​loop/​reportingplugins/​ocr3/​grpc_test.go Updates the registry argument in plugin tests.
pkg/​loop/​relayer_service.go Updates the relayer service constructor.
pkg/​loop/​internal/​types/​types.go Updates the plugin relayer interface.
pkg/​loop/​internal/​relayer/​test/​relayer.go Updates the test relayer implementation.
pkg/​loop/​internal/​relayer/​relayer.go Updates the relayer client signature.
pkg/​loop/​internal/​example-relay/​main.go Migrates the example relayer signature.
pkg/​loop/​internal/​core/​services/​reportingplugin/​ocr3/​test/​factory_generators.go Updates test factory signatures.
pkg/​loop/​internal/​core/​services/​reportingplugin/​ocr3/​reporting_plugin_service.go Updates the reporting plugin client signature.
pkg/​loop/​internal/​core/​services/​capability/​transport.go Uses registry types in transport helpers.
pkg/​loop/​internal/​core/​services/​capability/​capabilities_registry_test.go Updates registry type assertions.
pkg/​capabilities/​v2/​triggers/​http/​server/​trigger_server_gen.go Migrates the generated HTTP trigger registry field.
pkg/​capabilities/​v2/​triggers/​cron/​server/​trigger_server_gen.go Migrates the generated cron registry field.
pkg/​capabilities/​v2/​protoc/​pkg/​test_capabilities/​nodeaction/​server/​node_action_server_gen.go Updates the generated node-action fixture.
pkg/​capabilities/​v2/​protoc/​pkg/​test_capabilities/​importclash/​server/​clash_server_gen.go Updates the generated import-clash fixture.
pkg/​capabilities/​v2/​protoc/​pkg/​test_capabilities/​consensus/​server/​consensus_server_gen.go Updates the generated consensus fixture.
pkg/​capabilities/​v2/​protoc/​pkg/​test_capabilities/​basictrigger/​server/​basic_trigger_server_gen.go Updates the generated trigger fixture.
pkg/​capabilities/​v2/​protoc/​pkg/​test_capabilities/​basicaction/​server/​basic_action_server_gen.go Updates the generated action fixture.
pkg/​capabilities/​v2/​protoc/​pkg/​test_capabilities/​actionandtrigger/​server/​action_and_trigger_server_gen.go Updates the generated combined fixture.
pkg/​capabilities/​v2/​protoc/​pkg/​templates/​server.go.tmpl Generates direct registry imports and field types.
pkg/​capabilities/​v2/​consensus/​server/​consensus_server_gen.go Migrates the generated consensus registry field.
pkg/​capabilities/​v2/​chain-capabilities/​stellar/​server/​client_server_gen.go Migrates the generated Stellar registry field.
pkg/​capabilities/​v2/​chain-capabilities/​solana/​server/​client_server_gen.go Migrates the generated Solana registry field.
pkg/​capabilities/​v2/​chain-capabilities/​evm/​server/​client_server_gen.go Migrates the generated EVM registry field.
pkg/​capabilities/​v2/​chain-capabilities/​aptos/​server/​client_server_gen.go Migrates the generated Aptos registry field.
pkg/​capabilities/​v2/​actions/​http/​server/​client_server_gen.go Migrates the generated HTTP action registry field.
pkg/​capabilities/​v2/​actions/​confidentialworkflow/​server/​client_server_gen.go Migrates the confidential workflow registry field.
pkg/​capabilities/​v2/​actions/​confidentialhttp/​server/​client_server_gen.go Migrates the confidential HTTP registry field.
pkg/​capabilities/​registry/​base_test.go Uses the registry base interface directly in tests.

Review effort: Balanced

// Deprecated
type CapabilitiesRegistryBase = registry.CapabilitiesRegistryBase

type UnimplementedCapabilitiesRegistry struct {

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants