Repository navigation
feat: add Example09 (pool-based CCVs) and Example10 (policy engine) with fork tests - #50
Conversation
|
👋 SyedAsadKazmi, thanks for creating this pull request! To help reviewers, please consider creating future PRs as drafts first. This allows you to self-review and make any final changes before notifying the team. Once you're ready, you can mark it as "Ready for review" to request feedback. Thanks! |
andrejrakic
left a comment
andrejrakic
left a comment
There was a problem hiding this comment.
In general very good PR, thanks for opening. Added two minor comments for you to consider, but approved PR in the interest of time. Thanks
| // ---------------------------------------------------------------- | ||
|
|
||
| /// @notice Sets the maximum transfer amount this engine allows. | ||
| function setCap(uint256 newCap) external { |
There was a problem hiding this comment.
Anyone can call this function, but I can see the 10 ether cap is already defined in constructor, do we even need this function? If yes, let's add some access ownership here as a good hygiene, even though it's example contract.
| import {Script, console2} from "forge-std/Script.sol"; | ||
|
|
||
| import {AdvancedPoolHooks} from "@chainlink/contracts-ccip/contracts/pools/AdvancedPoolHooks.sol"; | ||
| import {IPolicyEngine} from "@chainlink/policy-management/interfaces/IPolicyEngine.sol"; |
There was a problem hiding this comment.
Unused import, I think the script should compile even without this line. Confirm please
…ages manually until indexer onboarding
Adds
Example09(pool-based CCVs) andExample10(policy engine) - scripts, book chapters, and fork tests - completingAdvancedPoolHookscoverage beyond the allowlist, withExample08's setup refactored onto a shared fork-test base.