Skip to content

Fix immutable-release preflight permission boundary #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moloch-- merged 3 commits into from
Aug 26, 2026
Merged

Fix immutable-release preflight permission boundary #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bbe21bf
Use protected review for immutable release preflight
moloch-- Aug 26, 2026
487a27d
Trigger protected workflow validation
moloch-- Aug 26, 2026
ab51669
Run unsigned package checks on branch pushes
moloch-- Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/workflows/package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
pull_request:
push:
branches:
- main
- "**"
tags:
- "v[0-9]+.[0-9]+.[0-9]+"

Expand Down Expand Up @@ -183,13 +183,11 @@ jobs:
echo "Tag commit is not contained in origin/main" >&2
exit 1
fi
immutable_releases="$(gh api \
-H 'X-GitHub-Api-Version: 2026-03-10' \
"repos/$GITHUB_REPOSITORY/immutable-releases" --jq .enabled)"
if [[ "$immutable_releases" != true ]]; then
echo "Repository immutable releases must be enabled before signing" >&2
exit 1
fi
# The immutable-releases settings endpoint requires repository
# administration permission, which GitHub does not grant to a
# workflow token. The protected armory-release reviewer verifies
# that setting before approving this job; the published release is
# then required to report .immutable == true below.
existing_release_id="$(gh api \
-H 'X-GitHub-Api-Version: 2026-03-10' \
"repos/$GITHUB_REPOSITORY/releases?per_page=100" \
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/reflektor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on:
pull_request:
push:
branches:
- main
- "**"

permissions:
contents: read
Expand Down