Skip to content

address cc changelog - #79

Merged
slbug merged 3 commits into
mainfrom
address-changelog
Nov 13, 2026
Merged

slbug merged 3 commits into
mainfrom
address-changelog

Conversation

@slbug

@slbug slbug commented Nov 13, 2026

Copy link
Copy Markdown
Owner

No description provided.

@slbug slbug self-assigned this Nov 13, 2026
@slbug
slbug requested a max review from Copilot November 13, 2026 17:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Several workflows consume agent results without explicit completion waits, risking missing or unfinished outputs, and the Ruby formatter lacks cancellation-safe temporary-file cleanup.

4 open issues
What changed in this PR

Prepares release 1.16.20 of the Ruby/Rails/Grape Claude Code plugin, aligning it with current agent-dispatch behavior and removing the obsolete subagent status-line integration.

Changes:

  • Remove the status-line setting, renderer, and installation hook.
  • Document agent-completion waits and update contributor hook and review guidance.
  • Align release metadata and refresh Markdown lint dependencies and overrides.
File Description
scripts/​fetch-claude-docs.sh Update status-line page comments only.
plugins/​ruby-grape-rails/​skills/​review/​SKILL.md Clarify dispatch and completion-wait instructions.
plugins/​ruby-grape-rails/​skills/​brainstorm/​SKILL.md Require research completion before artifact recovery.
plugins/​ruby-grape-rails/​settings.json Delete obsolete status-line configuration.
plugins/​ruby-grape-rails/​hooks/​scripts/​install-statusline-wrapper.sh Delete the unused wrapper installer.
plugins/​ruby-grape-rails/​hooks/​hooks.json Remove the status-line installation hook.
plugins/​ruby-grape-rails/​bin/​subagent-statusline Delete the status-line renderer.
plugins/​ruby-grape-rails/​.claude-plugin/​plugin.json Bump the plugin version to 1.16.20.
package.json Update version, linter dependency, and overrides.
package-lock.json Lock the refreshed dependency tree and version.
CHANGELOG.md Record the removal, guidance changes, and tooling updates.
.github/​instructions/​plugin-review.instructions.md Update settings and agent-wait review rules.
.github/​copilot-instructions.md Remove obsolete settings and binary references.
.claude/​skills/​docs-check/​references/​validation-rules.md Update plugin-settings validation guidance.
.claude/​skills/​docs-check/​references/​doc-pages.md Refresh status-line documentation descriptions.
.claude/​skills/​cc-changelog/​references/​analysis-rules.md Update settings-change impact mapping.
.claude/​rules/​skill-development.md Require explicit fanout completion waits.
.claude/​rules/​hook-development.md Document prompt timing and hook cancellation limits.
.claude/​rules/​agent-development.md Distinguish dispatch policy from runtime behavior.
.claude-plugin/​marketplace.json Align marketplace metadata and source tag with 1.16.20.

Review effort: Max

Comment thread .claude/rules/hook-development.md Resolved
Comment thread .claude/rules/skill-development.md Resolved

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Cancelled formatter hooks can continue and exit successfully, while the review workflow can save or apply verifier results before the verifier finishes.

1 open issue
1 previously missed issue

In code that hasn't changed since last review

Medium severity Wait for output-verifier completion before using its result

plugins/​ruby-grape-rails/​skills/​review/​SKILL.md:48

The Provenance Guard still runs output-verifier at line 228 and immediately saves and uses its result without waiting. Waiting for the initial reviewers does not cover this later agent, so interactive sessions can use a result before it exists. Require verifier completion before saving the sidecar or applying its findings.

4 resolved since last review

Review effort: Max

@slbug
slbug merged commit d528726 into main Nov 13, 2026
2 checks passed
@slbug
slbug deleted the address-changelog branch November 13, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants