You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The table defines CLAUDE.md as writable only when usable, but a present read-only file, directory, or unrelated symlink misses the first three rows and falls through to CLAUDE.md; with a usable AGENTS.md, the preceding row also offers that invalid target. Add an explicit stop row for a present unusable CLAUDE.md before either fallback.
The refreshed plugin-agent rules now recognize experimental.cacheTtl in plugin-review.instructions.md:29 and the docs-check rules, but this file's exhaustive valid-agent list still omits it. Both instruction files apply to plugins/**/agents/*.md, so reviewers receive contradictory guidance. Add the field here as well.
Document the symlink exception for usable AGENTS.md
This description omits the new symlink exception: the init contract targets a usable AGENTS.md without prompting when CLAUDE.md symlinks to it. As written, the tutorial promises a prompt in that supported state and disagrees with skills/init/SKILL.md:152 and the changelog.
The reason will be displayed to describe this comment to others. Learn more.
Copilot review overview
🔵 Needs a closer look
The initialization fallback can suppress an existing unusable AGENTS.md, and review guidance and regression tests remain inconsistent.
Review effort: Balanced Findings: None
Previously missed (4)
In code that hasn't changed since last review
Require args for interpreter-only hooks
lab/eval/tests/test_runtime_scripts.py:397
This test allows an interpreter-only hook ("command": "bash" or "ruby" with no args) to pass, even though such a hook would run no registered script. Assert that known interpreters always have an args array before continuing past shell-form commands.
Avoid CLAUDE.md fallback when unusable AGENTS.md exists
This fallback still creates CLAUDE.md when AGENTS.md exists but is read-only or a symlink. That immediately stops Claude Code from loading the existing AGENTS.md, which is the behavior this change is intended to avoid. Stop when AGENTS.md is present but unusable and no CLAUDE.md already exists.
Update review rules for newly documented skill frontmatter fields
This expands the documented skill frontmatter set, but .github/instructions/markdown-review.instructions.md:29-35 still defines the valid set without background, metadata, license, or compatibility. Update that review rule in the same PR (while retaining the explicit repo bans for when_to_use and plugin-scope paths) so reviewers do not report these newly documented fields as invalid.
Rewrite this shipped reference as direct actions. These descriptive feature summaries load into agent context and violate the repository's imperative-only convention for plugin Markdown.
This assumes an AGENTS.md block remains valid beside CLAUDE.md, but Claude Code stops loading AGENTS.md once a regular CLAUDE.md appears. Consequently the hook stays silent for a now-hidden managed block, and /rb:init --update leaves it hidden. Detect this state and direct migration to CLAUDE.md or require an explicit @AGENTS.md import.
This row can send the managed block to AGENTS.md even when CLAUDE.md or an unusable-but-present CLAUDE.local.md exists, although the loading rule below says either file prevents Claude Code from reading AGENTS.md. The install then succeeds but its stack notes never load. Offer AGENTS.md only when neither Claude memory file exists; otherwise target CLAUDE.md.
This issue also appears on line 189 of the same file.
Resolve conflict over prompting during --update migration
This prompt conflicts with the section contract at line 175, which says --update migration is “automatic, no prompt.” The agent receives mutually exclusive instructions. Either remove the no-prompt guarantee or define a deterministic file to retain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.