Repository navigation
Clarify Chapter 3 batch validation and typed conversion - #118
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A reader spotted that Chapter 3 checks each input's physical type in
validate_expression_inputsand again inColumnView<S>::try_from. The chapter's opening said to “validate a batch once,” which obscured the repeated check.Change
Clarify the one-page learner path: batch preflight checks arity, expected physical types, and equal row counts before traversal; the fallible typed conversion checks physical type again while constructing Array, Constant, or Indexed views. For unary evaluation, the validator's type comparison adds no independent safety over that conversion. The row-loop guarantee now follows both steps. No code, tests, API, or other chapter changed.
Review note
a2e49809e2556dfcd9abd410b04d7b0278d55b41; head3107905f9036447db391f2792ab268d11a97b73d. One Markdown path, +13/−5.mdbook build coursepassed;cargo test -p type-exercise-checkpoint-03-supplied-tests --lockedpassed (12 tests);git diff --checkpassed.AI-Assisted: GPT-6 Sol + Forge