This repository was archived by the owner on Feb 8, 2021. It is now read-only.
Separate agent and analyzer charts - #3
Open
Sparika wants to merge 8 commits into
Open
Conversation
Collaborator
|
Thanks @Sparika for this I generally like your approach (and I can see how this is useful for the multi cluster k8s use case). Please rebase |
hunchback
approved these changes
Feb 13, 2020
Author
|
hi @hunchback, thanks for the review. I have my hands full for the moment but I will rebase and show the result of the two commands once I have time to do it. |
Collaborator
great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change
The chart is separated into two subcharts. One is the skydive-analyzer chart and the other is the skydive-agent chart. The root chart control the deployment of both which allows to deploy through helm either only agent daemonset, only analyzer deployment, or both.
The parameters to control the deployment are
deployment.agentanddeployment.analyzer. Both parameters default totrueso the default behavior does not change.Parameters for each charts are located on their respective
values.yamlfiles but can be modified directly from the rootvalues.yamlfile. However, parameters must be prefixed by the sub-chart name as documented in the README.Additional changes