Add envtest integration tests for kube controller#2487
Conversation
|
@ajssmith @fgiorgetti @c-kruse Thoughts on this set up? For now just added integration tests for |
There was a problem hiding this comment.
Suggest a separate issue/pr for changes to NewClient as scope separate/independent from envtest integration
| } | ||
| time.Sleep(3 * time.Second) | ||
|
|
||
| if err := testEnv.Stop(); err != nil { |
There was a problem hiding this comment.
Suggest using defer function on Stop() following Start() above
| test: | ||
| go test ${TESTFLAGS} ./... | ||
|
|
||
| .PHONY: test-integration |
There was a problem hiding this comment.
Suggest moving the tests/Makefile unless there is a reason it needs to be here
|
|
||
| ## Layout | ||
|
|
||
| | Directory | Tests | |
There was a problem hiding this comment.
Suggest a layout that mirrors internal, e.g.
/tests/integration/kube/controller
In anticipation of integration tests for nonkube, e.g.
/tests/integration/nonkube/controller
2 participants
Fixes #2486