Added GetSslProfileName Unit Test#2476
Conversation
evanwang9x
force-pushed
the
Evan/Onboarding-Unit-Tests
branch
from
bcd2201 to
098703b
Compare
| t.Run(tt.name, func(t *testing.T) { | ||
| result := GetSslProfileName(tt.tlsCredentials, tt.useClientCert) | ||
| if result != tt.expected { | ||
| t.Errorf("got %q, want %q", result, tt.expected) |
There was a problem hiding this comment.
Consider using assert.Equal(t, tt.expected, result) here instead of t.Errorf , matches the style of the existing test in this file. Other than that LGTM.
There was a problem hiding this comment.
Alright I changed it to use assert.Equal
c-kruse
left a comment
c-kruse
left a comment
There was a problem hiding this comment.
Thank you @evanwang9x! Test looks good.
A more bookkeeping related thing we like to think about: The PR title and description are what tends to get recorded in our git history when we squash and merge it into main. For something small like this a more descriptive title would be plenty! We don't have codified commit message style guidance, but a quick glance here https://github.com/skupperproject/skupper/commits/main/ or git log main may help you get a feel for it.
evanwang9x
force-pushed
the
Evan/Onboarding-Unit-Tests
branch
from
098703b to
0b1875e
Compare
3 participants
Fixes #2475