Skip router ConfigMap entries when TLS credential secrets are missing#2449
Skip router ConfigMap entries when TLS credential secrets are missing#2449AryanP123 wants to merge 3 commits into
Conversation
990bf32 to
30510e0
Compare
30510e0 to
f0a59d1
Compare
5d69ec0 to
dddb71a
Compare
fgiorgetti
left a comment
There was a problem hiding this comment.
It worked well for me.
I have been able to create links and accesses resources without providing a secret and that did not prevent other resources from being reconciled and configured.
Restarting the skupper-router deployment worked fine without blocking the config-init container.
One comment, though, was the Listeners and Connectors that refer to tlsCredentials that do not exist, are processed without warning or errors on the CR status. It would be nice to get a similar behavior to what we have with Links and RouterAccesses.
c-kruse
left a comment
There was a problem hiding this comment.
I think we've got a few more things to work through before this gets released, but I'm happy to get it merged now and running in development before we work things out.
Quickly:
- It appears that Listener and Connector (and AttachedConnector I think) may never get configured after a missing tls secret is added without a spec change.
- I'm suspicious about the logging here, I suspect it will log (and re-log) a lot of redundant information that users should be getting from the resource status instead.
- We're missing MultiKeyListener logic - could be this work predates that resource.
- I'm vaguely concerned about the assumptions we make (outside of this changeset) on Site readiness in relation to RouterAccess readiness and configuration, and think we should play with it for a bit longer before resolving to change anything.
fgiorgetti
left a comment
There was a problem hiding this comment.
@AryanP123 Could you rebase your work on top of main? As @c-kruse pointed, this is missing MKL, Proxy and a few other changes already on main.
711938e to
b0d20bc
Compare
Fixes #2433