[__systemd_unit] add --unique-drop-in - #163
Conversation
|
Hmm, this is a tough one. However, this would be a breaking change, so 🤷. Another thing which caught my eye is the use of |
sideeffect42
left a comment
There was a problem hiding this comment.
I don't use systemd, so I don't really have an opinion.
6a7681b to
e6ef28c
Compare
e6ef28c to
b732f15
Compare
|
Moved this to separate parameter. Makes more sense this way, also compatibility. Also reminds me that this type is rather ugly and needs to be rewritten with all the known edge-cases. It's still in my TODO, but that will not happen today. |
From:
https://www.freedesktop.org/software/systemd/man/latest/systemd.unit.html
It's a feature, but I consider this a bug. But oh well, fix is simple - use unique names.
This bites me when I have service template e.g.
app@.servicewith drop-in and then alsoapp@instance.servicewith drop-in too. When both drop-ins are calledoverride.conf, then only last gets read.This "fix" is somewhat ugly, I agree, but I couldn't think anything more saner and I don't want to deal with it manually e.g. introduce new parameter and then set it when needed.