Skip to content

chore(release): wait for npm availability before announcement - #239

Merged
harlan-zw merged 2 commits into
mainfrom
fix/release-npm-availability
Oct 10, 2026
Merged

harlan-zw merged 2 commits into
mainfrom
fix/release-npm-availability

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

npm accepts uploads before the packages become available, so a GitHub release can advertise an unusable version. Wait for all ten release packages and their npm tags before publishing the GitHub release. Retry temporary registry failures for up to 15 minutes, then fail with the pending packages.

Release CI waits for all npm versions and tags before publishing the GitHub release

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-github-agent harlan-github-agent Bot added the harlan-agent-running An Agent holds a Task on this issue or pull request right now. label Oct 10, 2026
@harlan-zw harlan-zw added the harlan-agent-review Approve automated work for the current issue state or pull request head commit. label Oct 10, 2026
@harlan-github-agent harlan-github-agent Bot added the harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. label Oct 10, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent verification: ran the availability script against the live npm registry for v3.6.8. All ten package versions and their dist tags were available.

@harlan-github-agent

harlan-github-agent Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-10 16:23 UTC.

GitHub merged this pull request.

  • Logged (10/100): The pull request's screenshot evidence is unavailable, so its visual claims cannot be reviewed against pixels. View code Optional follow-up: Re-attach the screenshot or replace it with the textual CI log excerpt showing the wait step output, so reviewers can verify the behaviour.
    • Ask an agent to verify and fix this finding
  • Logged (20/100): A single malformed 200 registry response hard-fails the availability wait, contradicting the stated retry-then-fail-with-pending behaviour; a re-run recovers, so impact is limited. View code Optional follow-up: Catch the JSON.parse failure for a 200 body and return it as a Pending reason so the poll loop retries until the deadline, while keeping semantic mismatches (different package or version) as hard errors.
    • Ask an agent to verify and fix this finding
  • Logged (5/100): The new release script's real Node floor (22.6) is above the declared engines range (22.0.0), affecting only manual local runs since CI pins lts/*. View code Optional follow-up: Document the Node >=22.6 requirement beside the release script invocation, or drop the flag in favour of the default type stripping on current LTS.
    • Ask an agent to verify and fix this finding

b5a7d7e2-8788-4fef-a7c8-45baa8c2323d

Selected findings run after merge and open separate pull requests.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-review Approve automated work for the current issue state or pull request head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 10, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-zw
harlan-zw merged commit d19d25b into main Oct 10, 2026
4 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Oct 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant