Repository navigation
feat(cli): name each model reading in the approval message - #219
Merged
Merged
Conversation
skilld.dev now signs a non-required behavior-review check result: a language model's reading of each ask behavior match, such as a curl pipe quoted as an attack in a security guide. Without it the user sees only PATH:LINE and must open every file to tell an instruction from a quote. BEHAVIOR_CONFIRMATION_REQUIRED adds the reading after each match it names and says a language model wrote it. The gate still comes from skilld's own pattern match, so no reading can load a Skill or skip the approval. A finding in another shape, or a match named twice, adds nothing.
Merged
1 of 6 tasks
Collaborator
Author
|
Agent check (Claude, through Harlan Agent Kit). PR CI skips these, so I ran them on the head commit:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to skilld-dev/skilld.dev#538, which signs the readings this change prints.
❓ Type of change
📚 Description
A gated Skill stops with
BEHAVIOR_CONFIRMATION_REQUIREDand lists each match asPATH:LINE. Many matches are quotes, such ascurl ... | bashlisted as an attack in a security guide. The user has to open every file before approving.skilld.dev now signs a non-required
behavior-reviewcheck result: a language model's reading of eachaskmatch. The CLI reads its findings,PATH:LINE BEHAVIOR: VERDICT.and a reason, and adds each reading after its match in the approval message forrun,install, andupdate:The message then says a language model wrote each reading, and that a reading is no guarantee and changes no approval.
--allow.sanitize.Term proposal.
GLOSSARY.mdaddsbehavior reading, with the output labelmodel reading. It names a new concept and displaces no existing term.