Repository navigation
feat(install): add skilld to PATH in the shell profile - #201
Merged
Merged
Conversation
skilld.dev/cli now leads with install.sh, and it only printed a PATH hint. A new user who ran skilld next got command not found. install.ps1 already adds itself to the user PATH. SKILLD_NO_MODIFY_PATH=1 keeps the old hint.
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request.
12253a13-edc8-4630-934c-5c5d43421495 Selected findings run after merge and open separate pull requests. |
harlan-github-agent
Bot
added
harlan-agent-running
harlan-github-agent
Bot
removed
the
harlan-agent-review-required
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
1 of 6 tasks
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to skilld-dev/skilld.dev#449
❓ Type of change
📚 Description
skilld.dev/clinow leads withcurl -fsSL https://skilld.dev/install.sh | sh. That script only printed "Add ~/.skilld/bin to your PATH", so a new user who ranskilldnext got "command not found".install.ps1already adds itself to the user PATH on Windows.If
~/.skilld/binis not on PATH,install.shnow appends one line to the profile for$SHELL:$SHELL${ZDOTDIR:-$HOME}/.zshrcexport PATH=...~/.bashrc, or~/.bash_profileon macOSexport PATH=...~/.config/fish/conf.d/skilld.fishfish_add_path ...~/.profileexport PATH=...A reinstall finds the line and adds no second one. If the profile cannot be written, the script prints the line to add and still exits 0.
SKILLD_NO_MODIFY_PATH=1keeps the old hint and writes nothing.The installer tests now give each run its own
HOME, so no test can write to a real profile. The change reaches users with the next release, becauselatest/download/install.shserves the script from the latest release.