Repository navigation
fix(delivery): answer a renamed Skill run with its new name - #641
Merged
Merged
Conversation
Delivering a renamed Skill under its old name made skilld refuse it with SOURCE_MISMATCH, because the CLI checks that the Skill it receives carries the name it asked for. An old name now answers 404 with the command for the new name, which released CLIs show as written (ADR-0018).
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request.
Review completed. No finding above 80/100. Selected findings run after merge and open separate pull requests. |
harlan-github-agent
Bot
removed
harlan-agent-running
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
Follows #640.
skilld run harlan-zw/brundlefly/im-not-a-flyresolved to the renamedim-part-human, andskilldrefused it withSOURCE_MISMATCH: "skilld.dev delivered the Skill im-part-human, not the Skill this ref names". That check stops a registry from substituting one Skill for another, so a rename should not weaken it.An old Skill name now answers 404
SOURCE_NOT_FOUNDwith "The Skill im-not-a-fly was renamed to im-part-human. Run skilld run harlan-zw/brundlefly/im-part-human." Released CLIs show that detail as written, so no CLI release is needed.findSkillRunIdentitystops following Skill aliases, and/api/skills/run-identityreportsrenamedToinstead. ADR-0018 amends the run-command decision in ADR-0017.