Repository navigation
fix(search): open hero rows on click, one row per one-Skill repo - #541
Merged
Merged
Conversation
The hero box closes its panel on focusout. A press on a row cell moved focus to the body, so the panel unmounted before the click landed. Cancel the press so focus stays in the box. A Repository with one Skill showed two rows that open the same page. Keep the Skill row, which carries the run command.
harlan-zw
added
the
harlan-agent-review
Collaborator
Author
|
Agent check in a real browser, since CI cannot cover it:
|
harlan-github-agent
Bot
added
harlan-agent-review-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None.
❓ Type of change
📚 Description
A click on a row in the homepage search panel did nothing. Only Enter opened it. The hero box closes its panel on
focusout, and a row cell takes no focus. A press moved focus to the body, so the panel unmounted before the click landed. The row cell now cancelsmousedown, which keeps focus in the input. The header box has nofocusouthandler, so it was not affected.A query for a Repository with one Skill, such as
theBstar/shipreel, showed a Repository row and a Skill row that open the same page. The panel now shows the Skill row alone, because it carries the run command. Enter still opens that page.