Repository navigation
perf(trending): hydrate board rows past the head on view - #524
Merged
Merged
Conversation
A row that hydrates late misses its avatar's error event, so the board kept a gone owner's broken image. The mount now reads the image.
The board hydrated all thirty rows, every post included, before it responded. Rows past the first five now render on the server and hydrate once they scroll into view.
Collaborator
Author
|
Agent check (Claude Code, Harlan Agent Kit), since CI cannot cover it:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
/skills/trendingrenders about 4,400 elements: thirty rows, each with every post in its carousel. That HTML is deliberate, so crawlers and touch scrolling see every post. The cost was hydration: the page hydrated all thirty rows in one long task before it responded.BoardRankedListkeeps the first five rows as they were. The rest usehydrate-on-visible, so they render on the server unchanged and hydrate once they scroll into view. The element count stays the same.errorevent, and the board would keep a broken image for an owner whose account is gone._SkillCardIdentity.vuenow reads the image on mount and reports one that already failed.Five alternating Lighthouse 13.5 mobile runs of each build, cold cache, local
pnpm buildserved bywrangler dev, medians:The local board had 8 rows and no posts, so production, with 30 rows and their posts, defers more. The machine ran other builds at a load average of 69 to 107, so treat single runs as noisy; the builds alternated run by run to share that load.