Repository navigation
perf(artifact-delivery): run ten builds at once - #507
Merged
Merged
Conversation
Two build consumers finish about 20 builds a minute. A larger burst waits in the queue, and the CLI stops waiting after 60 s. Ten consumers run each build as before, one per invocation, so a large build keeps its subrequest budget. D1 and the read App's GitHub quota both hold at ten; the pull request states the numbers.
Contributor
🤖 READY · 88/100
|
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None. Launch prep for
skilld runlatency. Harlan approved this production config change.❓ Type of change
📚 Description
The
skilld-artifact-buildconsumer ran at most two builds at once. Builds took 4 to 7 s in production traces on 2026-10-07, so two consumers finish about 20 a minute. A larger burst waits in the queue, and the CLI stops waiting for a Resolution after 60 s. Queue delivery already took 1.2 s at the median and 3.4 s at worst in 20 timed runs. This raisesmax_concurrencyto 10 and keeps every other setting.skilld-devhas 5,000 requests an hour. #493 measured 7 requests for a first run pinned to a commit, 8 on a branch, and 0 for a repeat. That is about 700 first builds an hour, whatever the concurrency. Two consumers running 10 s cold builds already make about 12 a minute, or 5,000 requests an hour. At 10, a burst spends it sooner, then builds failRATE_LIMITEDwith a retry time, and signed-in runs fall back to their own token (#495).