Repository navigation
perf(cache): serve /cli and /developers from the edge cache - #502
Merged
Merged
Conversation
Both pages read no data and no session, yet every view rendered in the Worker and set a version cookie. The post-deploy proof now covers them and /skills/demos.
Collaborator
Author
|
Agent check (Claude Code, Harlan Agent Kit), since CI cannot cover it:
|
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 9e03ad6a-03e7-4060-9fbc-21f8b2bbc29d |
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Type of change
📚 Description
/cliand/developersread no data and no session, yet every view rendered in the Worker and set the__nkpvversion cookie. Both now carry anedgeCacherule like the other launch pages.They change only on deploy, and a deploy starts a new cache key, so the rule keeps a copy fresh for an hour and stale for nine more. The 36000s total matches the window nuxt-skew-protection keeps old chunks for. The
/clirule matches only/cli, so/cli/authorizestays uncached.pnpm production:edge-cachenow proves/cli,/developersand/skills/demosafter each deploy./skills/demosalready had a rule but no proof.Time to first byte from Sydney on 2026-10-07, three requests each:
/cli: 126 to 252 ms,cf-cache-status: BYPASS, and a__nkpvcookie on each answer./developers: 112 to 225 ms, the same way./,/skills/demos, a Skill page): 65 to 77 ms on aHIT.Workers Cache does not run under
wrangler dev, so the cached timing for these two pages exists only after deploy.