Skip to content

fix(artifact-delivery): fall back where GitHub denies the read App - #498

Merged
harlan-zw merged 4 commits into
mainfrom
fix/read-app-denied-fallback
Oct 7, 2026
Merged

harlan-zw merged 4 commits into
mainfrom
fix/read-app-denied-fallback

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Related to #491

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Since #491, public builds read GitHub as the skilld-dev-registry-reads App. GitHub denies that App on neondatabase/agent-skills, a public Repository that a personal token reads. The repository read answers 403, so every run of its Skills fails SOURCE_ACCESS_DENIED, which nobody retries. The sweep check and a run after the deploy on 2026-10-06 both failed this way.

A read the App was denied now repeats once with the next credential, ARTIFACT_GITHUB_TOKEN or GITHUB_TOKEN. The denial emits an artifact-github-credential event with the outcome app-denied and the Repository name, so the count of affected Repositories shows in the logs. A denial with no token after the App stays SOURCE_ACCESS_DENIED.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

…ies the App

neondatabase/agent-skills is public and a personal token reads it, but
GitHub answers the read App 403. Every run of its Skills failed
SOURCE_ACCESS_DENIED after builds moved to the App. A read the App was
denied now repeats once with ARTIFACT_GITHUB_TOKEN or GITHUB_TOKEN, and
the denial is reported as an artifact-github-credential event.
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 6, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 6, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-07 01:37 UTC.

GitHub merged this pull request.

  • Logged (15/100): The ops runbook does not describe the new app-denied event and the doubled reads per run of a denying Repository. View code
    • Ask an agent to verify and fix this finding

Review completed. No finding above 80/100.

Selected findings run after merge and open separate pull requests.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. labels Oct 6, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. labels Oct 6, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. labels Oct 7, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-blocked The automated Review found a material defect in this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 7, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: BLOCKED.

Read the Review results

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-blocked The automated Review found a material defect in this head commit. labels Oct 7, 2026
GitHub can answer a secondary rate limit with 403, quota left, and no
Retry-After. Only the message names the limit. That answer read as a
denial, so a limited read App fell back to GITHUB_TOKEN, a personal token
the registry sync also spends, and reported app-denied for a Repository
that never denied it. A 403 whose message names a rate limit is now
RATE_LIMITED, which never reaches the fallback token.
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-running An Agent holds a Task on this issue or pull request right now. label Oct 7, 2026
@harlan-zw
harlan-zw merged commit 992b016 into main Oct 7, 2026
6 checks passed
@harlan-github-agent harlan-github-agent Bot added the harlan-agent-running An Agent holds a Task on this issue or pull request right now. label Oct 7, 2026
@harlan-zw
harlan-zw deleted the fix/read-app-denied-fallback branch October 7, 2026 01:21
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-running An Agent holds a Task on this issue or pull request right now. label Oct 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant