Repository navigation
perf(artifact-delivery): answer Resolution polls when the build moves - #497
Merged
Merged
Conversation
A run waited for its build in one second steps, so the CLI saw a finished build up to a second after it landed. A read of a building Resolution now waits up to 8 seconds for its next state, checking every 250 ms, and the poll interval drops to 250 ms. The queue send took 446 to 500 ms of each Resolution request in three production traces. The CLI polls for the result anyway, so the send now runs after the response. A send that fails settles the Resolution as a retryable SERVICE_UNAVAILABLE, so the CLI requests a new one.
Contributor
🤖 MERGED
GitHub merged this pull request.
3b248c89-e379-4f82-86e6-a80b398cdc34 Selected findings run after merge and open separate pull requests. |
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: BLOCKED.
1 of 6 tasks
harlan-zw
added this pull request to stack #509
October 6, 2026 16:22
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None. Launch prep for
skilld runlatency.❓ Type of change
📚 Description
A run spends most of its time waiting for its build, and two parts of that wait were fixed costs.
pollAfterMs: 1000, so the CLI saw a finished build up to a second after it landed. In every timed production run on 2026-10-07, the CLI polled once every 1.1 to 1.2 s. A read of a building Resolution now waits up to 8 seconds for its state to change, checking D1 every 250 ms, and the answer namespollAfterMs: 250. A settled Resolution answers at once. Released CLIs follow the interval the server names, so they need no update.POST /api/v1/resolutions, from Sydney and Bangkok, the queue send took 446 to 500 ms of a 588 to 1,738 ms request. The send now runs inwaitUntilafter the response. A send that fails settles the Resolution as a retryableSERVICE_UNAVAILABLE, so the polling CLI requests a new Resolution instead of waiting out its 60 second deadline.