Repository navigation
fix(artifact-signer): sign the previous policy through a deploy - #485
Merged
Merged
Conversation
The deploy updates the signer before the site, and a failed smoke rolls the site back alone. In both windows the running site stages statements under the policy before the signer's, and the signer refused them, so every run in the window failed after the queue retries ran out. The signer now signs the previous policy too, judged by that policy's checks.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request.
cd27231a-9391-4cc5-bf88-6ba6eb9ec064 Selected findings run after merge and open separate pull requests. |
harlan-zw
added
the
harlan-agent-review-required
harlan-github-agent
Bot
added
harlan-agent-pending
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: PENDING.
1 of 6 tasks
harlan-zw
added a commit
that referenced
this pull request
Oct 6, 2026
#485 merged first. The signer's previous policy entry moves from 2026-08-20.1 to 2026-10-07.1, the policy this branch bumps from. The bump only loosens checks, so the signer keeps signing .1 through a deploy.
harlan-github-agent
Bot
removed
the
harlan-agent-pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #481
❓ Type of change
📚 Description
#481 noted that the Artifact signer updates before the site, so a build the old site checked in that window cannot be signed. The signer refused any statement under another
ARTIFACT_POLICY_VERSIONwithPOLICY_OUTDATED. The staged statement never changes, so each queue retry was refused again until the Resolution failed asSERVICE_UNAVAILABLE. A failed smoke makes this worse: it rolls the site back alone, and the signer then refuses every build until the next deploy.The signer now signs the current policy and the one before it.
SIGNABLE_ARTIFACT_POLICIESinchecks.tslists both with the checks each one requires, so a previous policy statement is judged by its own checks. The site still reuses only builds under the current policy. A policy bump replaces the previous entry, or leaves it out when the bump closes a safety gap.