Repository navigation
fix(home): trim the hero bottom padding on phones - #476
Merged
Merged
Conversation
Below 64rem the hero reserved 112px under the Agent logos for a 104px texture strip, which read as a large empty gap before the lifecycle band. A 64px strip still shows the names and frees 40px.
Collaborator
Author
|
Agent check, since CI cannot cover it: applied the same two values to live skilld.dev in headless Chrome.
|
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request.
f6d5142c-66d4-469b-863d-e0a27baeb03c Selected findings run after merge and open separate pull requests. |
harlan-github-agent
Bot
added
harlan-agent-pending
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
harlan-github-agent
Bot
added
harlan-agent-ready
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None.
❓ Type of change
📚 Description
On phones and tablets the home hero left a large empty gap under the Agent logos. The hero reserved 112px there for a 104px Skill name texture strip.
Below 64rem, the hero bottom padding drops from
7remto4.5remand the strip from6.5remto4rem. The hero is 40px shorter and the strip still shows its names. The desktop rule is unchanged.