Repository navigation
feat(trending): fold posts behind faces and show the board on home - #468
Merged
Merged
Conversation
The homepage showed six trending repository cards, which named no Skill and offered no run command. The week board already ranks Skills with their posts, so the homepage now shows its head. The board mapping moves to shared so both pages rank the same way.
Collaborator
Author
|
Agent check, run by hand since CI cannot cover it. Local dev server, with production feed data proxied in:
|
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. The pull request closed. |
harlan-github-agent
Bot
added
harlan-agent-running
Every trending row carried a full post card under it, which tripled its height on the board, the homepage, and track pages. A row now spends one line on the description and one on why it ranked: up to three poster circles that open the carousel, then the first post as a quote. The braille spark moves beside the Skill name. Closed posts stay in the server HTML.
harlan-github-agent
Bot
removed
the
harlan-agent-running
harlan-zw
changed the title
Collaborator
Author
|
Agent check for b854fd7, run by hand on a local dev server with production feed data:
|
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
removed
the
harlan-agent-review
harlan-github-agent
Bot
removed
the
harlan-agent-review-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
None.
❓ Type of change
📚 Description
Every trending row carried a full post card and pager under it. That tripled the row's height on
/skills/trending, on track pages, and in the homepage section this PR adds. A row now spends one line on what the Skill does and one on why it ranked: up to three poster circles, then the first post as a quote. The circles open the post carousel. The third circle counts the rest, so the braille spark moves beside the Skill name without its count. Closed posts stay in the server HTML. The row drops from 292px to 78px on desktop, and from 377px to 163px on a phone.The homepage trending section showed six repository cards. They named no Skill and offered no run command. It now shows the top three rows of the week board, and "All trending skills" opens the week range. The feed mapping moves from the trending page into
feedBoardRowsinshared/trending-range.ts, so both pages rank Skills the same way. The homepage sends the same/api/feed/trendingrequest as before, and its payload carries only the three rows.SkillCardgains aflagslot beside the name and adescriptionLinesprop.DESIGN.mdrecords the new row.