Repository navigation
fix(skills): close the SkillCard review findings from #453 - #457
Merged
Merged
Conversation
A refused clipboard left the run pill silent, so a visitor had no way to get the command. The pill now shows it selected, as the run chip does, and the card's copy returns its result so the pill can tell. The curator profile built SKILL.md links no card shows, and /me asked for one its API never sends. Both are gone. DESIGN.md now names the trending entries the card's row layout replaces. Repository rows in the home update feed kept their old style beside the compact Skill rows. They now use the card's measures.
harlan-zw
added
the
harlan-agent-review
Collaborator
Author
|
🤖 Agent comment. Checked in a browser, since CI cannot show it: a local dev server serving the home feeds from production, Chrome headless at 1440 and 390 wide. Repository rows in "Recently updated" now match the compact Skill rows beside them. The hovered row is
|
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request.
Review completed. No finding above 80/100. Selected findings run after merge and open separate pull requests. |
harlan-github-agent
Bot
added
harlan-agent-running
harlan-github-agent
Bot
added
harlan-agent-running
harlan-github-agent
Bot
removed
the
harlan-agent-running
harlan-github-agent
Bot
removed
the
harlan-agent-review-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #453
❓ Type of change
📚 Description
The Review of #453 logged four findings, and the production smoke test of #453 found one more gap. This fixes all five.
copynow returns itsInstallCopyResult, so the pill can tell./me: the list asked for a SKILL.md link that its API never sends. It now uses the card's default actions.