Repository navigation
feat(weekly): draw the braille spark on email trending rows - #447
Merged
Merged
Conversation
DESIGN.md says the braille spark marks the email's trending section, as it does on the board since #431. The email still showed counts only, so a reader could not tell a burst of posts on one day from a steady week.
harlan-zw
added
the
harlan-agent-review
Collaborator
Author
|
Agent check, since CI cannot cover it:
|
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request.
c1099435-7cb3-4776-b334-38e4157f975e Selected findings run after merge and open separate pull requests. |
harlan-github-agent
Bot
added
harlan-agent-ready
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #431
❓ Type of change
📚 Description
The weekly email's trending rows said how many accounts mentioned a Skill, but not when. The board has drawn the braille spark since #431, and
DESIGN.mdsays the spark marks the email's trending section too.Each trending row now shows seven days of mentions beside its title, followed by the count, in both the HTML and plain-text parts. It reuses
shared/braille-spark.tsand thementionsByDaythatloadTrendingSkillsalready returns, carried on thenamedandnamed-and-starsreasons. Star surge rows, filler rows, and rows whose posts are all older than seven days show no spark.Two choices differ from the board:
aria-labelcarries the count and the per-day numbers. The font stack names a braille face per platform: Apple Braille, Segoe UI Symbol, Noto Sans Symbols 2, then DejaVu Sans Mono.