Skip to content

test(smoke): check a rendered Skill page in production - #445

Merged
harlan-zw merged 1 commit into
mainfrom
fix/skill-page-production-smoke
Oct 6, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
fix/skill-page-production-smoke

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Production smoke checks missed the Skill page failure because they covered no individual Skill page. Check /gh/anthropics/skills/skill-creator for HTTP 200 and its rendered Skill heading. Error pages and empty shells fail the deploy check.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 6, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 6, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-06 01:07 UTC.

GitHub merged this pull request.

  • Logged (45/100): The new check's retry budget is shorter than the Skill page's 300s edge cache, so a cached broken page can produce false deploy failures after a fix ships. View code
    • Ask an agent to verify and fix this finding

bfd68ece-ee1e-402d-bb10-bb280295fa4a

Selected findings run after merge and open separate pull requests.

@harlan-zw

Copy link
Copy Markdown
Collaborator Author

🤖 Agent verification against production:

Ran the updated smoke check against https://skilld.dev. All 18 route checks passed on their first attempt, including /gh/anthropics/skills/skill-creator. The page rendered its Skill heading. Asset coherence and featured collection checks also passed.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-pending The automated Review is waiting on a gate for this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 6, 2026

@harlan-github-agent harlan-github-agent Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-pending The automated Review is waiting on a gate for this head commit. labels Oct 6, 2026
@harlan-zw
harlan-zw merged commit ba852a5 into main Oct 6, 2026
7 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Oct 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant