Repository navigation
fix(brand-kit): build run refs from the Skill name - #430
Merged
Merged
Conversation
The trending feed's slug is owner/name, so brand-kit run chips printed owner/repo/owner/name and copied a command the CLI rejects.
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-review-required
harlan-zw
added
the
harlan-agent-review-required
harlan-github-agent
Bot
added
the
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 3eb0e692-ace3-407c-a6de-d6618bcb2105 |
harlan-github-agent
Bot
added
harlan-agent-pending
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: PENDING.
harlan-github-agent
Bot
removed
the
harlan-agent-pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #427 and #429
❓ Type of change
📚 Description
The trending feed in
server/api/feed/trending.get.tsreturns each Skill'sslugasowner/name. The/brand-kitrun chips used that slug as the Skill name, so they printednpx skilld run owner/repo/owner/name. The CLI rejects that ref, and every copy sent it to analytics.The page now builds run refs from
skill.name, the same field the home page uses in #429.