Repository navigation
fix(home): let touch swipes on the trending rail scroll the page - #424
Merged
Merged
Conversation
The hero rail scrolled under touch and its overscroll containment kept the page still, so a swipe that started on it went nowhere on phones.
harlan-zw
added
the
harlan-agent-review
Collaborator
Author
|
Agent check, since CI cannot cover it: I ran emulated touch swipes in headless Chrome at 375px with touch input, against live skilld.dev with this rule injected.
|
harlan-github-agent
Bot
added
harlan-agent-review-required
Contributor
🤖 MERGED
GitHub merged this pull request. No material findings were recorded. 193a18d5-ab5a-473d-8d0a-4fa6a216e520 |
harlan-github-agent
Bot
added
harlan-agent-pending
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
harlan-github-agent
Bot
added
harlan-agent-ready
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #419
❓ Type of change
📚 Description
On phones, a swipe that starts on the hero's trending rail scrolls the rail, and
overscroll-behavior: containkeeps the page still. The rail fills most of the screen there, so scrolling down the homepage often goes nowhere.On coarse pointers the stream in
SkillSourceListnow usesoverflow-y: hiddenand resetsoverscroll-behavior-block, so touch scrolls the page. The rail keeps scrolling itself, and mouse and trackpad users can still scroll it by hand.