Repository navigation
fix(home): compact signpost doors on phones - #422
Merged
Merged
Conversation
#419 renamed the homepage H2s, so the door titles under the hero drifted from the sections they open. On phones the doors stacked as full cards and cost 639px of scroll before the first section.
Collaborator
Author
|
Agent check, since CI cannot cover it: I injected this branch's CSS and titles into live skilld.dev in headless Chrome.
|
harlan-github-agent
Bot
added
harlan-agent-running
Contributor
🤖 MERGED
GitHub merged this pull request.
59ddd343-5d41-4cf1-8218-98545b5afe6b Selected findings run after merge and open separate pull requests. |
harlan-zw
added
the
harlan-agent-review
harlan-github-agent
Bot
added
harlan-agent-pending
![harlan-github-agent[bot]](https://avatars.githubusercontent.com/in/4579275?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Harlan Agent Kit posted this automated review. AI open source policy.
Automated Review: READY.
harlan-github-agent
Bot
added
harlan-agent-ready
harlan-github-agent
Bot
removed
the
harlan-agent-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
Related to #419
❓ Type of change
📚 Description
#419 renamed the homepage H2s, but the three doors under the hero kept their old titles. "Watch it change" opens a section titled "Keep up with skill changes".
On phones the doors also stack as full cards, 639px tall at 375px wide, before the first section starts. Each section intro repeats the door text.
The door titles now match their H2s. Below 48rem each door is one row with its icon, title, and arrow, and the door text is hidden. That block is 163px at 375px wide. Tablet and desktop keep the three-column doors.