Skip to content

feat(identity): add account and authentication app layouts - #415

Merged
harlan-zw merged 1 commit into
mainfrom
feat/account-app-shell
Oct 5, 2026
Merged

harlan-zw merged 1 commit into
mainfrom
feat/account-app-shell

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Account management currently shares the public site layout and puts Skills beside every account setting.
Add a NuxtSEO Pro style sidebar for account tools and agent setup, using skilld's existing design tokens.
Give authentication a focused layout and separate Skills, email, watched Repositories, and account settings through URL-selected views.
Public discovery keeps its existing layout, and agent setup remains available without signing in.

Layout routing connects focused authentication and the account shell to existing account APIs

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Written by the Agent.

Checked the app at 375px, 768px, and desktop widths, in light and dark themes.
The mobile drawer closes on its close button, Escape, and navigation. Focus returns to the menu button.
CLI and MCP setup modes still change through the URL. Keyboard shortcut help opens within the app shell.
Authentication preserves the account return URL and displays OAuth errors.
Account view and mutation checks used component fixtures. A live GitHub OAuth sign-in was outside these local checks.

Agent setup within the account shell
Focused authentication
Mobile navigation with close control and backdrop

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 5, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 5, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-05 08:10 UTC.

GitHub merged this pull request.

  • Logged (20/100): Every image the PR cites as visual proof is inaccessible, so the claimed responsive and a11y verification cannot be checked by any reviewer. View code
    • Ask an agent to verify and fix this finding
  • Logged (22/100): Keyboard search shortcuts silently stop working on all auth-layout routes and each press fires a wasted typeahead fetch. View code
    • Ask an agent to verify and fix this finding
  • Logged (15/100): Every emailed settings link now lands on the skills view, one sidebar click away from the controls it names. View code
    • Ask an agent to verify and fix this finding

23b4e714-2771-44fa-9bf1-ff7d18c5c23d

Selected findings run after merge and open separate pull requests.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 5, 2026

@harlan-github-agent harlan-github-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-zw
harlan-zw merged commit 8da259f into main Oct 5, 2026
7 checks passed
@harlan-zw
harlan-zw deleted the feat/account-app-shell branch October 5, 2026 08:02
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant