Skip to content

fix(checkin): detect unusable X discovery read budgets - #410

Merged
harlan-zw merged 3 commits into
mainfrom
fix/x-budget-observation
Oct 5, 2026
Merged

harlan-zw merged 3 commits into
mainfrom
fix/x-budget-observation

Conversation

@harlan-zw

@harlan-zw harlan-zw commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Related to #179.

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

X discovery cannot use a remainder below its minimum request size, but the check-in missed that exhaustion.
Read the request minimum from the same source as the ceiling and flag unusable remainders.
Record distinct X Posts within the observation day and preserve unknown flags when the source is incomplete.
Report instructions now describe projected spend as a Post-only estimate with actual billing unavailable.

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 5, 2026
@harlan-zw

harlan-zw commented Oct 5, 2026 •

Copy link
Copy Markdown
Collaborator Author

Harlan Agent Kit wrote this verification note.

Read-only production queries on 2026-10-05 showed 1,992 returned discovery reads today.
Only eight reads remained, below X search's ten-result minimum.
The old check-in flag reported false for this input.

D1 snapshots filtered to X recorded 498 distinct Posts on October 4 and 499 on October 5, a partial UTC day.
This corrects the earlier counts, which included Bluesky in the shared snapshot table.
These combine discovery and refresh. They do not identify actual billed usage or author-expansion charges.
X pricing describes soft deduplication within each UTC day.
Treat the existing dollar projection as a Post-only estimate.

#409 fixes repeated first-page discovery reads independently.
Measure complete UTC days after it lands before changing the query or ceiling for #179.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 5, 2026
@harlan-github-agent

harlan-github-agent Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

🤖 MERGED

Harlan Agent Kit posted this automated review. It is not Harlan's personal review or approval. AI open source policy. Last updated: 2026-10-05 07:52 UTC.

GitHub merged this pull request.

No material findings were recorded.

7cab0470-156f-41fb-91b7-ea2a442a9a36

@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-running An Agent holds a Task on this issue or pull request right now. label Oct 5, 2026
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 5, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 5, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

🤖 Harlan Agent Kit Agent assessment of head 6d91dda3c1b302fa82d5d760f6540a02c35b03e6.

The Service reported CapacityUnavailable. Its exact-head Review was stopped before an independent Agent reviewed the complete diff.

The review found no defects. All 15 focused tests passed. Confidence: 95/100, with five points deducted for focused coverage.

This is an independent Agent assessment. The Service Review for this head remains stopped.

@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. label Oct 5, 2026
@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 5, 2026
@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. harlan-agent-pending The automated Review is waiting on a gate for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. labels Oct 5, 2026

@harlan-github-agent harlan-github-agent Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harlan Agent Kit posted this automated review. AI open source policy.

Automated Review: READY.

Read the Review results

@harlan-github-agent harlan-github-agent Bot added harlan-agent-ready The automated Review passed every gate on this head commit. and removed harlan-agent-pending The automated Review is waiting on a gate for this head commit. labels Oct 5, 2026
@harlan-zw
harlan-zw merged commit cd7e8c4 into main Oct 5, 2026
7 checks passed
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-ready The automated Review passed every gate on this head commit. label Oct 5, 2026
@harlan-zw
harlan-zw deleted the fix/x-budget-observation branch October 5, 2026 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant