Skip to content

fix(ui): correct Skill attribution and onboarding controls - #400

Merged
harlan-zw merged 4 commits into
mainfrom
fix/onboarding-replay-20261005
Oct 5, 2026
Merged

harlan-zw merged 4 commits into
mainfrom
fix/onboarding-replay-20261005

Conversation

@harlan-zw

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

Related to #397.

❓ Type of change

  • 📖 Documentation
  • 🐞 Bug fix
  • 👌 Enhancement
  • ✨ New feature
  • 🧹 Chore
  • ⚠️ Breaking change

📚 Description

Hero cards attributed Skills to social posters. The account email field lost its label after reload.

This restores maintainer attribution and keeps account textboxes named. Remaining onboarding controls gain 44px targets and rose checkboxes.

The login sizing and watch-save recovery changes are handled in #397.

Hero Skill cards resolve names from repository owners

🤖 AI disclosure: Harlan Agent Kit modified this description. My AI open-source policy.

@harlan-zw harlan-zw added the harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. label Oct 5, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

Agent browser evidence for 2004e27af8cd51d78b8ffdc78dd1bcdfb55f8a2d, using a local built Worker and synthetic account.

The current production trending fixture renders Addy Osmani beside addyosmani/agent-skills. Hard reload /me, then open email settings: Email address names the textbox. At 375px, Import and Continue are 44px high, Skip is 44px square, and inline recovery is 44px high.

Production before Local candidate after
Production hero attributes Addy's Skill to Yarchi Candidate hero attributes Addy's Skill to Addy Osmani

Account email field after hard reload

@harlan-github-agent harlan-github-agent Bot added harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit. and removed harlan-agent-review Pull request triage requires an adversarial Review. Adding this label manually always forces one. labels Oct 5, 2026
@harlan-zw

Copy link
Copy Markdown
Collaborator Author

🤖 Harlan Agent Kit Agent assessment of head 2004e27.

The premise is sound. Fresh independent review found no findings. Exact-head CI passed.

The PR skill permitted fallback review because seven queued reviews exceeded five free host slots. The Service confirmed Stopped for this exact head. This assessment is separate from a Service READY outcome.

The reviewer read all seven changed files and surrounding code. It inspected every PR image using the exact local originals. Mobile controls, maintainer attribution, and account label wiring showed no defect.

Review confidence: 95/100. Deduction: limited independent runtime coverage, 5.

Harlan Agent Kit provided this independent Agent assessment. Human merge decision required.

@harlan-github-agent harlan-github-agent Bot added harlan-agent-running An Agent holds a Task on this issue or pull request right now. and removed harlan-agent-running An Agent holds a Task on this issue or pull request right now. labels Oct 5, 2026
@harlan-github-agent harlan-github-agent Bot removed the harlan-agent-running An Agent holds a Task on this issue or pull request right now. label Oct 5, 2026
@harlan-zw
harlan-zw merged commit 8ecc7b1 into main Oct 5, 2026
6 checks passed
@harlan-zw
harlan-zw deleted the fix/onboarding-replay-20261005 branch October 5, 2026 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

harlan-agent-review-required Pull request triage requires an adversarial Review for this head commit.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant