Allow noteblock to play multiple pitches in same frame

[MrDuck557]

I only changed logic because that is the only way it is feasibly happening

[MrDuck557]

yes this works, given that I'm playing bad apple on a single noteblock without any note drops

[sk7725]

You need a way to limit this (10 sounds per 10 ticks) or make the noteblock unable to play identical pitches in the same frame, snynoe with a malicious intent or just a beginner at logic can easily play wind3.ogg @ipt times per tick, which is unfortunate if you do be happening to be wearing earphones or something

[MrDuck557]

unable to play identical pitches in the same frame

I'll try doing this

[MrDuck557]

playing wind3 60 times a second is still earsplitting, but it can't break your eardrums at 1500 times a second
it still works the same

[sk7725]

the new implementation looks horrible, doing 72 calculations every play attempt.
I myself don't see a good solution, just make your music players not so compact

[MrDuck557]

ok do you want me to reinit the array
also it's still constant time
as well at being a fairly light operation (setting a variable isn't difficult)
and it's not every play attempt, it's every play attempt that isn't on the same frame

[MrDuck557]

Doing the operation 1,000,000,000 times takes 12,438 milliseconds, which means each one takes 12.438 nanoseconds
Initing a new array 1,000,000,000 times takes 15,549 milliseconds, which is more than the current operation and takes 15.549 nanoseconds
In order to lag the game by one millisecond relative to before this pr you would need to fire 80,398 noteblocks at the same time
Note that these tests were done in a separate program, so it may not be perfectly accurate