Skip to content

Update uchardet to 0.0.7, modernize Xcode project - #5

Open
amake wants to merge 11 commits into
siuying:masterfrom
amake:update
Open

amake wants to merge 11 commits into
siuying:masterfrom
amake:update

Conversation

@amake

@amake amake commented Sep 10, 2020

Copy link
Copy Markdown

There have been significant updates to uchardet since the last release of this pod.

I have

  • Updated to upstream (now at gitlab.freedesktop.org) to the latest release, 0.0.7
    • Supports many new encodings
    • However the returned names of the encodings have changed to be compliant with iconv, so there are breaking changes
  • Update pod version to 2.0.0 due to breaking changes
  • Updated the Xcode project according to the recommendations of Xcode 11.7
  • Fixed warnings in the tests
  • Ensured that pod lib lint passes
  • Updated the xctool invocation syntax for the latest version of xctool, though it doesn't work for me on Catalina due to code signing issues

- Remove `src` group
- Re-add `src` folder as group, targeting the test projects (don't "copy as
  needed")
- Remove src/{,tools/}CMakeLists.txt from all targets as they will conflict
Per error upon `pod lib lint --verbose`:

```
clang: warning: libstdc++ is deprecated; move to libc++ with a minimum deployment target of OS X 10.9 [-Wdeprecated]
ld: library not found for -lstdc++
clang: error: linker command failed with exit code 1 (use -v to see invocation)
```
@amake
amake changed the base branch from update to master September 10, 2020 13:48
@amake

amake commented Sep 28, 2020

Copy link
Copy Markdown
Author

Gentle bump

Are you still maintaining this pod, or should I see about publishing my own?

@amake

amake commented Oct 21, 2020

Copy link
Copy Markdown
Author

@siuying indicated on Twitter that he isn't interested in maintaining this anymore, so I've published these changes as UniversalDetector2 (also on CocoaPods).

I will leave this PR open in case he ever changes his mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant