Repository navigation
Feature/id based resource location - #16
Open
sitepark-veltrup wants to merge 52 commits into
Open
sitepark-veltrup wants to merge 52 commits into
sitepark-veltrup wants to merge 52 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16 +/- ##
=========================================
Coverage 96.90% 96.90%
Complexity 231 231
=========================================
Files 25 25
Lines 613 613
=========================================
Hits 594 594
Misses 19 19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sitepark-veltrup
changed the base branch from
main
to
feature/initial-implementation
March 20, 2026 08:03
Brings the branch to the tooling state of the other atoolo packages: phpstan 2.2.14, composer-normalize 2.53.0, phpunit 10.5.64 and php-cs-fixer 3.95.26, phplint via composer instead of phive, the php range >=8.1 <8.6.0 verified by both phpcs.compatibilitycheck.xml and the CI matrix. Conflicts resolved: - composer.json keeps this branch's 24 dependencies and takes the wider php range; analyse:phplint now calls ./vendor/bin/phplint - composer.lock stays untracked, as it is on this branch - a bundle resolves fresh, and main tracking it was the outlier - the tool configurations take main's state Three findings that only phpstan 2 reports are fixed along the way, in LabelTranslator and EmailSender. The 16 findings that were already there under phpstan 1.12 are untouched - they are this branch's own and want a separate look. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
phpstan reported 16 findings on this branch, unnoticed because CI calls it with "|| true". Most of them trace back to two wrong type declarations rather than to the code: - @phpstan-type DelivererConfig was missing a comma after "showEmpty: bool", so the parser stopped there and the whole "selectable" key was lost from the type. That is why EmailSender's isset() on it was reported as impossible. - Both DelivererModel and DelivererConfig described "selectable" as a single entry, while transformProcessorConfig() builds a map of selection key to config and appends to selectable[$key]['to']. EmailSender's own @PARAM shape did not list the key at all. The remaining ones are narrowings where a decoded structure meets a typed signature, plus the redundant "?? ''" fallbacks on an address "name" that the shape declares as required. One finding pointed at a real gap: the JsonSchema alias had no "deliverer" member although FormDataModelFactory::control() reads it, which made the flag permanently false and the deliverer variable dead. No behaviour changes; the 126 tests pass unchanged. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
…into feature/id-based-resource-location
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary adjustments for the ID-based resource layout