[OMEGA-430] Abort omega launcher start when script and Docker image versions differ - #364
Open
janaina-senna wants to merge 5 commits into
Open
janaina-senna wants to merge 5 commits into
janaina-senna wants to merge 5 commits into
Conversation
Author
|
Manual test of the matching scenario: Manual test of the mismatching scenario: |
Author
|
Unit tests for matching and mismatching scenarios were added: |
vsbogd
reviewed
Sep 25, 2026
vsbogd
left a comment
Member
There was a problem hiding this comment.
The idea is right, but there is the excessive complexity in processing Omega versions. The problem is that instead of use bare version the code gets something like "Omega version ...." and tries to figure out version from this string. I would suggest get bare version from Python function instead.
Next question is what function to use. The function returning Omega version is
Line 221 in ee0618a
- one returns bare version or empty string
- another returns the formatted version if it is needed (personally I would not format version here at all and format it in the code which prints/sends the version instead)
Then we can get bare version using python -c ... command and postprocessing is not needed, code will be simpler overall.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Abort
scripts/omega start(and the interactive bootstrap) when the host launcher version and the Docker image version are both known and do not match.The check runs after
docker pulland beforedocker rm -f omega. Host version comes fromomega_version(); image version is read from/PeTTa/repos/Omega/version, with a fallback to the image'sscripts/omega --version. A trailing-dirtysuffix is ignored so a locally dirty checkout of the same tag is not a false mismatch.If either version cannot be determined (
Omega unknown, typicalcurl | bashwith no git metadata), the script warns and continues so the documented pipe-install path still works.README now states that the launcher and image must be the same git tag.
How Has This Been Tested?
bash -n scripts/omega./scripts/omega --versiontests/test_omegaclaw_launcher.py:startand still issuesdocker rm/docker runChecklist