Removing the fdb-backup task runner in favor of the FDB Operator CRDs - #428
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Simplyblock Operator Helm control plane deployment to remove the dedicated fdb-backup task-runner container, aligning backup/restore responsibility with the FoundationDB Operator’s native CRDs instead of an in-pod Docker-based runner.
Changes:
- Removes the
tasks-runner-fdb-backupcontainer from the control plane Deployment template. - Eliminates the associated command/env wiring for the removed container (e.g., Prometheus env injection via the common container snippet).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
geoffrey1330
approved these changes
Aug 14, 2026
mxsrc
approved these changes
Aug 14, 2026
mxsrc
left a comment
mxsrc
left a comment
Contributor
There was a problem hiding this comment.
Removing code is the best PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the recently added fdb-backup task runner from the control plane deployment. It is built to use Docker and doesn't work in Kubernetes environment. Instead of adjusting it to support Docker and Kubernetes, the easier and more obvious (thanks @mxsrc for bringing up the obvious 😅) solution is to use the FDB Operator-internal backup and restore functionality.
Required documentation: simplyblock/documentation#196