Skip to content

fix: remove hardcoded secret in cli.js (CWE-798) #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: remove hardcoded secret in cli.js (CWE-798) #28

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions bin/cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ const cli = new Command()
.usage('-u <username> -p <password> -f <file> [additional-options]')
.helpOption('-h, --help', 'output this help message and exit')
.requiredOption('-u, --username <string>', 'your Apple ID')
.requiredOption('-p, --password <string>', 'app-specific password for your Apple ID')
.option('-p, --password <string>', 'app-specific password for your Apple ID (insecure, prefer IOS_UPLOADER_PASSWORD env var)')
.requiredOption('-f, --file <string>', 'path to .ipa file for upload (local file or http(s):// URL)')
.option('-c, --concurrency <number>', 'number of concurrent upload tasks to use', 4)
.option('-s, --status', 'display upload status and exit');
Expand Down Expand Up @@ -188,10 +188,17 @@ export async function run() {

const options = cli.opts();

// Prefer the password from the environment to avoid exposing it via the process list.
const password = process.env.IOS_UPLOADER_PASSWORD || options.password;
if (!password) {
console.error('Missing password: set the IOS_UPLOADER_PASSWORD environment variable or pass -p/--password.');
process.exit(1);
}

// Context variable keeping track of all the necessary information for upload procedure.
const ctx = {
username: options.username,
password: options.password,
password,
filePath: options.file,
concurrency: options.concurrency,
status: options.status,
Expand Down