Align release decisions and validate governance inputs - #2
Merged
Conversation
simaba
marked this pull request as ready for review
August 12, 2026 04:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
release,release_with_conditions,hold,do_not_release, anddefer.holdinstead of automatically collapsing it into a terminal rejection.Why
The documentation defined five distinct governance outcomes, while the Python policy implemented only three. In particular, missing critical controls were emitted as
no_go, which erased the distinction between a remediable hold and an explicit do-not-release decision. The policy also accepted truthy non-Boolean evidence values, which could silently turn malformed input into a passing gate.Compatibility / behavior
decision_contextis optional.GO,CONDITIONAL_GO,NO_GO) remain available as aliases.decisionvalues intentionally change to the framework vocabulary and are documented in the changelog and usage guide.Validation
python -m unittest discover -s tests -v: 22 tests pass locally.python -m compileallpasses forsrc/andtests/.release; the high-risk ADAS example now correctly evaluates toholdwhen hard controls are incomplete.