Repository navigation
Conversation
axelboc
commented
Oct 15, 2026
| fetchOpts: Omit<RequestInit, 'signal'> = {}, | ||
| fetchOpts: { | ||
| headers?: Record<string, string>; | ||
| } & Omit<RequestInit, keyof FetcherOptions> = {}, |
Contributor
Author
There was a problem hiding this comment.
I still give the flexibility to pass fetch options like credentials, etc. but not the options that only make sense on a per-request basis (FetcherOptions).
Passing headers is explicitly allowed in a Record format so they can be merged easily
Comment on lines
+18
to
+19
| export interface FetcherOptions extends Pick<RequestInit, 'method' | 'body'> { | ||
| headers?: Record<string, string>; |
Contributor
Author
There was a problem hiding this comment.
FetcherOptions now includes only the options that are actually used by the providers.
Comment on lines
+104
to
+108
| method, | ||
| headers: { ...defaultHeaders, ...headers }, | ||
| body, | ||
| signal: abortSignal, | ||
| ...moreFetchOpts, |
Contributor
Author
There was a problem hiding this comment.
Now we know exactly what's going on and users can't mistakenly pass an option to createBasicFetcher that makes no sense or gets overridden.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
headers(passed tocreateBasicFetcher) were being overridden by localheaders(passed to the actual fetcher).headersas well asmethodandbodywere simply not used. This was a complete oversight.